You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/26 21:13:34 UTC
[native-toolchain-CR] Parallelize image building process
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12864
Change subject: Parallelize image building process
......................................................................
Parallelize image building process
Images can now be built in parallel when using the new buildall.py
script. Other than the parallelism and logging changes, the script
behaves the same way.
Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
---
M docker/README.md
A docker/buildall.py
D docker/buildall.sh
3 files changed, 57 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/64/12864/1
--
To view, visit http://gerrit.cloudera.org:8080/12864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Parallelize image building process
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12864 )
Change subject: Parallelize image building process
......................................................................
Parallelize image building process
Images can now be built in parallel when using the new buildall.py
script. Other than the parallelism and logging changes, the script
behaves the same way.
Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
---
M docker/README.md
A docker/buildall.py
D docker/buildall.sh
3 files changed, 57 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/64/12864/3
--
To view, visit http://gerrit.cloudera.org:8080/12864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Parallelize image building process
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12864 )
Change subject: Parallelize image building process
......................................................................
Patch Set 3: Verified+1 Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12864/3/docker/buildall.py
File docker/buildall.py:
http://gerrit.cloudera.org:8080/#/c/12864/3/docker/buildall.py@49
PS3, Line 49: sys.exit(exit)
I didn't realise you could pass strings to sys.exit() so I looked at the docs and learned something new.
--
To view, visit http://gerrit.cloudera.org:8080/12864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:15:08 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Parallelize image building process
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12864 )
Change subject: Parallelize image building process
......................................................................
Parallelize image building process
Images can now be built in parallel when using the new buildall.py
script. Other than the parallelism and logging changes, the script
behaves the same way.
Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Reviewed-on: http://gerrit.cloudera.org:8080/12864
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M docker/README.md
A docker/buildall.py
D docker/buildall.sh
3 files changed, 57 insertions(+), 39 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 5
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Parallelize image building process
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12864 )
Change subject: Parallelize image building process
......................................................................
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I526b0088020bb7c647f1918b3eb3258cc1e3ddf9
Gerrit-Change-Number: 12864
Gerrit-PatchSet: 4
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:20:13 +0000
Gerrit-HasComments: No