You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/08/12 17:32:02 UTC

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24684


Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................

IMPALA-14759: Upgrade to boost 1.91.0

This bumps the version of Boost to 1.91.0. This includes a new
open addressing hash table and other updates.

Boost bumped its requirement for the C++ standard in some
libraries, and Avro was using an older C++ standard. This
bumps the version of Avro C++ to 1.12.0, which fixes the
issue.

Testing:
 - Built Impala with the new Boost and ran tests

Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
---
M buildall.sh
D source/avro/avro-1.11.1-patches/0001-fix-cpp-build-error.patch
A source/avro/avro-1.12.0-patches/0001-Respect-cxx-flags-from-build.patch
M source/avro/build-cpp.sh
D source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
A source/boost/boost-1.91.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
6 files changed, 38 insertions(+), 669 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/84/24684/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 3: Verified+1

I built the toolchain on x86_64 and ARM. I ran a core job with the corresponding Impala patches, and it passed. Going ahead with this.


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Aug 2026 15:38:23 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Aug 2026 15:10:42 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2026 13:01:12 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Zoltan Borok-Nagy, Michael Smith, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24684

to look at the new patch set (#3).

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................

IMPALA-14759: Upgrade to boost 1.91.0

This bumps the version of Boost to 1.91.0. This includes a new
open addressing hash table and other updates.

Boost bumped its requirement for the C++ standard in some
libraries, and Avro was using an older C++ standard. This
bumps the version of Avro C++ to 1.12.2, which fixes that
issue. Avro has also been working to eliminate the Boost
dependency, and it is now only needed when building the tests.
This specifies AVRO_BUILD_TESTS=OFF to eliminate Avro C++'s
dependency on Boost

Testing:
 - Built Impala with the new Boost and ran tests

Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
---
M buildall.sh
D source/avro/avro-1.11.1-patches/0001-fix-cpp-build-error.patch
A source/avro/avro-1.12.2-patches/0001-Respect-cxx-flags-from-build.patch
M source/avro/build-cpp.sh
D source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
A source/boost/boost-1.91.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
6 files changed, 40 insertions(+), 674 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/84/24684/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 2: Verified-1

I missed something and this needs a fix


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2026 18:51:28 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Aug 2026 01:19:37 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................

IMPALA-14759: Upgrade to boost 1.91.0

This bumps the version of Boost to 1.91.0. This includes a new
open addressing hash table and other updates.

Boost bumped its requirement for the C++ standard in some
libraries, and Avro was using an older C++ standard. This
bumps the version of Avro C++ to 1.12.2, which fixes that
issue. Avro has also been working to eliminate the Boost
dependency, and it is now only needed when building the tests.
This specifies AVRO_BUILD_TESTS=OFF to eliminate Avro C++'s
dependency on Boost

Testing:
 - Built Impala with the new Boost and ran tests

Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Reviewed-on: http://gerrit.cloudera.org:8080/24684
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
D source/avro/avro-1.11.1-patches/0001-fix-cpp-build-error.patch
A source/avro/avro-1.12.2-patches/0001-Respect-cxx-flags-from-build.patch
M source/avro/build-cpp.sh
D source/boost/boost-1.74.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
A source/boost/boost-1.91.0-patches/0001-Fix-hidden-visibility-symbols-for-LLVM.patch
6 files changed, 40 insertions(+), 674 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[native-toolchain-CR] IMPALA-14759: Upgrade to boost 1.91.0

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24684 )

Change subject: IMPALA-14759: Upgrade to boost 1.91.0
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I669dd6d998a72ca855ec3a374bd31db17ce1c9b0
Gerrit-Change-Number: 24684
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Aug 2026 18:10:23 +0000
Gerrit-HasComments: No