You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by 康愈圆 <ky...@mails.tsinghua.edu.cn> on 2019/10/11 11:07:39 UTC
Implement Delete Storage Group SQL interface [IOTDB-188]
Hi, all
I'm now working on issue #188. I will implement delete storage group sql interface.
Best,
___________________
Yuyuan KANG
Re: Implement Delete Storage Group SQL interface [IOTDB-188]
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,
> The related PR is #440. Multiple storage groups deletion will be suppoted, like "SET STORAGE GROUP TO root.ln.wf01.wt01, root.ln.wf01.wt02, root.ln.wf01.wt03".
As far as I know, we do not support setting multiple storage groups in one sql, but it would be great if we support.
> I added and implemented "analyzeMetaDataDeleteFileLevel" method in LogicalGenerator.java, to generate the logical plan of storage group deletion.
'FileLevel' is the ancient version of 'StorageGroup', try to use 'StorageGroup' in all places.
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "康愈圆" <ky...@mails.tsinghua.edu.cn>
> 发送时间: 2019-10-12 10:37:36 (星期六)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: Implement Delete Storage Group SQL interface [IOTDB-188]
>
> Hi, all
>
> The related PR is #440. Multiple storage groups deletion will be suppoted, like "SET STORAGE GROUP TO root.ln.wf01.wt01, root.ln.wf01.wt02, root.ln.wf01.wt03".
>
> I implemented it by defining the grammer in ANTLR.
>
> I added and implemented "analyzeMetaDataDeleteFileLevel" method in LogicalGenerator.java, to generate the logical plan of storage group deletion.
>
> In StorageEngine, "deleteStorageGroup" is also modified. I added "if" statement to check whether the prosessor is null. If the storage group is not in processorMap, it can be null. It happens when a user set a storage group but doesn't insert any data in it. Then if the user tries to delete the storage group, the previous code will throw null pointer exception, which should be aviod.
>
> Best,
> _____________________
> Yuyuan KANG
>
> > -----原始邮件-----
> > 发件人: "康愈圆" <ky...@mails.tsinghua.edu.cn>
> > 发送时间: 2019-10-11 19:07:39 (星期五)
> > 收件人: dev@iotdb.apache.org
> > 抄送:
> > 主题: Implement Delete Storage Group SQL interface [IOTDB-188]
> >
> > Hi, all
> >
> >
> > I'm now working on issue #188. I will implement delete storage group sql interface.
> >
> >
> >
> >
> > Best,
> > ___________________
> > Yuyuan KANG
Re: Implement Delete Storage Group SQL interface [IOTDB-188]
Posted by 康愈圆 <ky...@mails.tsinghua.edu.cn>.
Hi, all
The related PR is #440. Multiple storage groups deletion will be suppoted, like "SET STORAGE GROUP TO root.ln.wf01.wt01, root.ln.wf01.wt02, root.ln.wf01.wt03".
I implemented it by defining the grammer in ANTLR.
I added and implemented "analyzeMetaDataDeleteFileLevel" method in LogicalGenerator.java, to generate the logical plan of storage group deletion.
In StorageEngine, "deleteStorageGroup" is also modified. I added "if" statement to check whether the prosessor is null. If the storage group is not in processorMap, it can be null. It happens when a user set a storage group but doesn't insert any data in it. Then if the user tries to delete the storage group, the previous code will throw null pointer exception, which should be aviod.
Best,
_____________________
Yuyuan KANG
> -----原始邮件-----
> 发件人: "康愈圆" <ky...@mails.tsinghua.edu.cn>
> 发送时间: 2019-10-11 19:07:39 (星期五)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Implement Delete Storage Group SQL interface [IOTDB-188]
>
> Hi, all
>
>
> I'm now working on issue #188. I will implement delete storage group sql interface.
>
>
>
>
> Best,
> ___________________
> Yuyuan KANG