You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/11/07 17:16:42 UTC

[GitHub] trafficserver pull request #1206: TS-4838: CONNECT requests get forgotten ac...

GitHub user PSUdaemon opened a pull request:

    https://github.com/apache/trafficserver/pull/1206

    TS-4838: CONNECT requests get forgotten across threads.

    What happens here is that ProxyClientTransaction::adjust_thread
    reschedules the transaction onto a new thread at the start of
    HttpSM::do_http_server_open.
    
    Unfortunately, at this point the default handler is
    HttpSM::state_raw_http_server_open. When the transaction is
    rescheduled, the default handler runs, and receives the EVENT_INTERVAL
    that it so fortuitously logs an error for. We have never actually
    completed do_http_server_open, so we never make any more progress
    on this transaction.
    
    (cherry picked from commit 8fddd77c085d1a64f11de61bb42a50562cd23229)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PSUdaemon/trafficserver bp-1002

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1206
    
----
commit c5ab2e686ac0dad4ebe89573cdcc0b2d2a6359a4
Author: James Peach <jp...@apache.org>
Date:   2016-09-09T22:29:05Z

    TS-4838: CONNECT requests get forgotten across threads.
    
    What happens here is that ProxyClientTransaction::adjust_thread
    reschedules the transaction onto a new thread at the start of
    HttpSM::do_http_server_open.
    
    Unfortunately, at this point the default handler is
    HttpSM::state_raw_http_server_open. When the transaction is
    rescheduled, the default handler runs, and receives the EVENT_INTERVAL
    that it so fortuitously logs an error for. We have never actually
    completed do_http_server_open, so we never make any more progress
    on this transaction.
    
    (cherry picked from commit 8fddd77c085d1a64f11de61bb42a50562cd23229)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1206: TS-4838: CONNECT requests get forgotten across th...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1206
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1189/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1206: TS-4838: CONNECT requests get forgotten across th...

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1206
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1082/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1206: TS-4838: CONNECT requests get forgotten ac...

Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:

    https://github.com/apache/trafficserver/pull/1206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---