You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/04/04 18:38:14 UTC

[camel] branch main updated: static methods don't need final keyword, it's senseless (#9797)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new ee6cb9c709e static methods don't need final keyword, it's senseless (#9797)
ee6cb9c709e is described below

commit ee6cb9c709efce51031bb444bf191b49c52c85a9
Author: dk2k <dk...@users.noreply.github.com>
AuthorDate: Tue Apr 4 21:38:06 2023 +0300

    static methods don't need final keyword, it's senseless (#9797)
    
    Co-authored-by: dk2k <dk...@ya.ru>
---
 .../camel/component/reactive/streams/ReactiveStreamsComponent.java  | 2 +-
 .../component/sql/stored/template/generated/TokenMgrError.java      | 2 +-
 .../src/main/java/org/apache/camel/xml/io/MXParser.java             | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/components/camel-reactive-streams/src/main/java/org/apache/camel/component/reactive/streams/ReactiveStreamsComponent.java b/components/camel-reactive-streams/src/main/java/org/apache/camel/component/reactive/streams/ReactiveStreamsComponent.java
index df3bf2ca023..c4524e6028b 100644
--- a/components/camel-reactive-streams/src/main/java/org/apache/camel/component/reactive/streams/ReactiveStreamsComponent.java
+++ b/components/camel-reactive-streams/src/main/java/org/apache/camel/component/reactive/streams/ReactiveStreamsComponent.java
@@ -190,7 +190,7 @@ public class ReactiveStreamsComponent extends DefaultComponent {
     // Helpers
     // ****************************************
 
-    public static final ReactiveStreamsComponent withServiceType(String serviceType) {
+    public static ReactiveStreamsComponent withServiceType(String serviceType) {
         ReactiveStreamsComponent component = new ReactiveStreamsComponent();
         component.setServiceType(serviceType);
 
diff --git a/components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/TokenMgrError.java b/components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/TokenMgrError.java
index 9e2ce9cf1f1..c20c8309271 100644
--- a/components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/TokenMgrError.java
+++ b/components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/TokenMgrError.java
@@ -47,7 +47,7 @@ public class TokenMgrError extends Error
    * Replaces unprintable characters by their escaped (or unicode escaped)
    * equivalents in the given string
    */
-  protected static final String addEscapes(String str) {
+  protected static String addEscapes(String str) {
     StringBuilder retval = new StringBuilder();
     char ch;
     for (int i = 0; i < str.length(); i++) {
diff --git a/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java b/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
index c7b77cc684b..cd3a1e04b39 100644
--- a/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
+++ b/core/camel-xml-io/src/main/java/org/apache/camel/xml/io/MXParser.java
@@ -284,7 +284,7 @@ public class MXParser implements XmlPullParser {
      * to compute - so it also means diminishing hash quality for long strings
      * but for XML parsing it should be good enough ...
      */
-    protected static final int fastHash(char ch[], int off, int len) {
+    protected static int fastHash(char ch[], int off, int len) {
         if (len == 0)
             return 0;
         // assert len >0
@@ -2976,13 +2976,13 @@ public class MXParser implements XmlPullParser {
     protected static boolean lookupNameStartChar[] = new boolean[LOOKUP_MAX];
     protected static boolean lookupNameChar[] = new boolean[LOOKUP_MAX];
 
-    private static final void setName(char ch)
+    private static void setName(char ch)
     // { lookupNameChar[ (int)ch / 32 ] |= (1 << (ch % 32)); }
     {
         lookupNameChar[ch] = true;
     }
 
-    private static final void setNameStart(char ch)
+    private static void setNameStart(char ch)
     // { lookupNameStartChar[ (int)ch / 32 ] |= (1 << (ch % 32)); setName(ch); }
     {
         lookupNameStartChar[ch] = true;