You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2014/06/09 19:48:11 UTC
[VOTE] Plugins Release (attempt 2)
Please review and vote on the release of this plugins release.
Release issue: https://issues.apache.org/jira/browse/CB-6877
The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-6877/
The packages were published from their corresponding git tags:
cordova-plugin-camera: 0.3.0 (4fa934e06f)
cordova-plugin-console: 0.2.9 (f3764d8318)
cordova-plugin-device: 0.2.10 (159d55eb1d)
cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
cordova-plugin-device-orientation: 0.3.7 (d66777a007)
cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
cordova-plugin-file: 1.2.0 (e02d3d0f8e)
cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
cordova-plugin-media: 0.2.11 (ee68987d3b)
cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
cordova-plugin-network-information: 0.2.9 (be5875f9d9)
cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
cordova-plugin-statusbar: 0.1.6 (11195658af)
cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
I am getting failing tests for contacts + battery. I have decided not
to release them until they get reviewed.
Upon a successful vote I will upload the archives to dist/, upload
them to the Plugins Registry, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 72 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ensured tests were passing on iOS & Android by using createmobilespec script
* Ran coho verify-tags with above output succssfully
Re: [VOTE] Plugins Release (attempt 2)
Posted by Steven Gill <st...@gmail.com>.
If you are interested in checking out the latest tag in each of the plugin
repos, you can run the following command from the parent directory. This
assumes all of the plugins are siblings.
for l in cordova-plugin-*;do (cd $l; git checkout $(git describe --tags
--abbrev=0)); done;
To test the camera plugin, you can then do cordova plugin add
../cordova-plugin-camera (path depends on where your test project is in
relation to plugin)
Note: If you have uncommitted local changes in plugin repos, this won't
work. You will have to either commit or stash them.
I am going to see if I can publish these to our registry under the RC tag.
So to test, you would be able to go cordova plugin add
org.apache.cordova.camera@rc (similar to tools release)
Hope this helps.
On Mon, Jun 9, 2014 at 12:33 PM, Marcel Kinard <cm...@gmail.com> wrote:
> +1
>
> - Ran coho audit-license-headers, all looks good.
> - Ran coho verify-tags, all looks good.
> - Ran mobile-spec using Android Cordova platform 3.5.0 on Android 4.4.3.
> Ignoring the fails in Battery and Contacts, I see 2 other failing tests in
> Geolocation which I am tempted to ignore because this plugin is empty for
> Android since it falls back to the webview implementation for geolocation.
>
> On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
>
> > cordova-plugin-camera: 0.3.0 (4fa934e06f)
> > cordova-plugin-console: 0.2.9 (f3764d8318)
> > cordova-plugin-device: 0.2.10 (159d55eb1d)
> > cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
> >
> > cordova-plugin-device-orientation: 0.3.7 (d66777a007)
> > cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
> > cordova-plugin-file: 1.2.0 (e02d3d0f8e)
> > cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
> > cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
> >
> > cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
> > cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
> > cordova-plugin-media: 0.2.11 (ee68987d3b)
> > cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
> > cordova-plugin-network-information: 0.2.9 (be5875f9d9)
> >
> > cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
> > cordova-plugin-statusbar: 0.1.6 (11195658af)
> > cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
>
>
Re: [VOTE] Plugins Release (attempt 2)
Posted by Steven Gill <st...@gmail.com>.
The vote has now closed. The results are:
Positive Binding Votes: 5
Steve Gill
Andrew Grieve
Marcel Kinard
Piotr Zalewa
Bryan Higgins
The vote has passed.
On Tue, Jun 10, 2014 at 6:54 AM, Bryan Higgins <br...@bryanhiggins.net>
wrote:
> +1
>
> - coho audit-license-headers
> - coho verify-tags
> - mobile-spec on cordova-blackberry@3.5.0
>
> One failure for FT upload abort which I'll look into, but it's definitely
> not a show stopper considering the improvements in this release.
>
>
>
> On Tue, Jun 10, 2014 at 7:21 AM, Piotr Zalewa <pz...@mozilla.com> wrote:
>
> > +1 I've installed plugins and checked these which exist on Firefox OS
> >
> > Dnia Mon Jun 9 22:43:41 2014 Marcel Kinard pisze:
> >
> > I also verified the contents of the zip files against my local repos at
> >> that hash (diff -r). All looks good.
> >>
> >> On Jun 9, 2014, at 3:33 PM, Marcel Kinard <cm...@gmail.com> wrote:
> >>
> >> +1
> >>>
> >>> - Ran coho audit-license-headers, all looks good.
> >>> - Ran coho verify-tags, all looks good.
> >>> - Ran mobile-spec using Android Cordova platform 3.5.0 on Android
> 4.4.3.
> >>> Ignoring the fails in Battery and Contacts, I see 2 other failing
> tests in
> >>> Geolocation which I am tempted to ignore because this plugin is empty
> for
> >>> Android since it falls back to the webview implementation for
> geolocation.
> >>>
> >>> On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com>
> wrote:
> >>>
> >>> cordova-plugin-camera: 0.3.0 (4fa934e06f)
> >>>> cordova-plugin-console: 0.2.9 (f3764d8318)
> >>>> cordova-plugin-device: 0.2.10 (159d55eb1d)
> >>>> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
> >>>>
> >>>> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
> >>>> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
> >>>> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
> >>>> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
> >>>> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
> >>>>
> >>>> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
> >>>> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
> >>>> cordova-plugin-media: 0.2.11 (ee68987d3b)
> >>>> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
> >>>> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
> >>>>
> >>>> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
> >>>> cordova-plugin-statusbar: 0.1.6 (11195658af)
> >>>> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
> >>>>
> >>>
> >>>
> >>
> >>
> > --
> > Piotr Zalewa
> > Mozilla
> >
>
Re: [VOTE] Plugins Release (attempt 2)
Posted by Bryan Higgins <br...@bryanhiggins.net>.
+1
- coho audit-license-headers
- coho verify-tags
- mobile-spec on cordova-blackberry@3.5.0
One failure for FT upload abort which I'll look into, but it's definitely
not a show stopper considering the improvements in this release.
On Tue, Jun 10, 2014 at 7:21 AM, Piotr Zalewa <pz...@mozilla.com> wrote:
> +1 I've installed plugins and checked these which exist on Firefox OS
>
> Dnia Mon Jun 9 22:43:41 2014 Marcel Kinard pisze:
>
> I also verified the contents of the zip files against my local repos at
>> that hash (diff -r). All looks good.
>>
>> On Jun 9, 2014, at 3:33 PM, Marcel Kinard <cm...@gmail.com> wrote:
>>
>> +1
>>>
>>> - Ran coho audit-license-headers, all looks good.
>>> - Ran coho verify-tags, all looks good.
>>> - Ran mobile-spec using Android Cordova platform 3.5.0 on Android 4.4.3.
>>> Ignoring the fails in Battery and Contacts, I see 2 other failing tests in
>>> Geolocation which I am tempted to ignore because this plugin is empty for
>>> Android since it falls back to the webview implementation for geolocation.
>>>
>>> On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
>>>
>>> cordova-plugin-camera: 0.3.0 (4fa934e06f)
>>>> cordova-plugin-console: 0.2.9 (f3764d8318)
>>>> cordova-plugin-device: 0.2.10 (159d55eb1d)
>>>> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
>>>>
>>>> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
>>>> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
>>>> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
>>>> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
>>>> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
>>>>
>>>> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
>>>> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
>>>> cordova-plugin-media: 0.2.11 (ee68987d3b)
>>>> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
>>>> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
>>>>
>>>> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
>>>> cordova-plugin-statusbar: 0.1.6 (11195658af)
>>>> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
>>>>
>>>
>>>
>>
>>
> --
> Piotr Zalewa
> Mozilla
>
Re: [VOTE] Plugins Release (attempt 2)
Posted by Piotr Zalewa <pz...@mozilla.com>.
+1 I've installed plugins and checked these which exist on Firefox OS
Dnia Mon Jun 9 22:43:41 2014 Marcel Kinard pisze:
> I also verified the contents of the zip files against my local repos at that hash (diff -r). All looks good.
>
> On Jun 9, 2014, at 3:33 PM, Marcel Kinard <cm...@gmail.com> wrote:
>
>> +1
>>
>> - Ran coho audit-license-headers, all looks good.
>> - Ran coho verify-tags, all looks good.
>> - Ran mobile-spec using Android Cordova platform 3.5.0 on Android 4.4.3. Ignoring the fails in Battery and Contacts, I see 2 other failing tests in Geolocation which I am tempted to ignore because this plugin is empty for Android since it falls back to the webview implementation for geolocation.
>>
>> On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
>>
>>> cordova-plugin-camera: 0.3.0 (4fa934e06f)
>>> cordova-plugin-console: 0.2.9 (f3764d8318)
>>> cordova-plugin-device: 0.2.10 (159d55eb1d)
>>> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
>>>
>>> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
>>> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
>>> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
>>> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
>>> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
>>>
>>> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
>>> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
>>> cordova-plugin-media: 0.2.11 (ee68987d3b)
>>> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
>>> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
>>>
>>> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
>>> cordova-plugin-statusbar: 0.1.6 (11195658af)
>>> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
>>
>
>
--
Piotr Zalewa
Mozilla
Re: [VOTE] Plugins Release (attempt 2)
Posted by Marcel Kinard <cm...@gmail.com>.
I also verified the contents of the zip files against my local repos at that hash (diff -r). All looks good.
On Jun 9, 2014, at 3:33 PM, Marcel Kinard <cm...@gmail.com> wrote:
> +1
>
> - Ran coho audit-license-headers, all looks good.
> - Ran coho verify-tags, all looks good.
> - Ran mobile-spec using Android Cordova platform 3.5.0 on Android 4.4.3. Ignoring the fails in Battery and Contacts, I see 2 other failing tests in Geolocation which I am tempted to ignore because this plugin is empty for Android since it falls back to the webview implementation for geolocation.
>
> On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
>
>> cordova-plugin-camera: 0.3.0 (4fa934e06f)
>> cordova-plugin-console: 0.2.9 (f3764d8318)
>> cordova-plugin-device: 0.2.10 (159d55eb1d)
>> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
>>
>> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
>> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
>> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
>> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
>> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
>>
>> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
>> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
>> cordova-plugin-media: 0.2.11 (ee68987d3b)
>> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
>> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
>>
>> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
>> cordova-plugin-statusbar: 0.1.6 (11195658af)
>> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
>
Re: [VOTE] Plugins Release (attempt 2)
Posted by Marcel Kinard <cm...@gmail.com>.
+1
- Ran coho audit-license-headers, all looks good.
- Ran coho verify-tags, all looks good.
- Ran mobile-spec using Android Cordova platform 3.5.0 on Android 4.4.3. Ignoring the fails in Battery and Contacts, I see 2 other failing tests in Geolocation which I am tempted to ignore because this plugin is empty for Android since it falls back to the webview implementation for geolocation.
On Jun 9, 2014, at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
> cordova-plugin-camera: 0.3.0 (4fa934e06f)
> cordova-plugin-console: 0.2.9 (f3764d8318)
> cordova-plugin-device: 0.2.10 (159d55eb1d)
> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
>
> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
>
> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
> cordova-plugin-media: 0.2.11 (ee68987d3b)
> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
>
> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
> cordova-plugin-statusbar: 0.1.6 (11195658af)
> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
Re: [VOTE] Plugins Release (attempt 2)
Posted by Andrew Grieve <ag...@chromium.org>.
+1
- Verified that hashes match the tags.
- Verified hashes & sigs
- Verified contents of plugin-camera (assuming others are fine)
On Mon, Jun 9, 2014 at 1:48 PM, Steven Gill <st...@gmail.com> wrote:
> Please review and vote on the release of this plugins release.
>
> Release issue: https://issues.apache.org/jira/browse/CB-6877
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-6877/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-camera: 0.3.0 (4fa934e06f)
> cordova-plugin-console: 0.2.9 (f3764d8318)
> cordova-plugin-device: 0.2.10 (159d55eb1d)
> cordova-plugin-device-motion: 0.2.8 (51d58d6d29)
>
> cordova-plugin-device-orientation: 0.3.7 (d66777a007)
> cordova-plugin-dialogs: 0.2.8 (057d6cc4e9)
> cordova-plugin-file: 1.2.0 (e02d3d0f8e)
> cordova-plugin-file-transfer: 0.4.4 (db9eca0aa8)
> cordova-plugin-geolocation: 0.3.8 (a403b4abb6)
>
> cordova-plugin-globalization: 0.2.8 (9a4e8c81e5)
> cordova-plugin-inappbrowser: 0.5.0 (992306bbc5)
> cordova-plugin-media: 0.2.11 (ee68987d3b)
> cordova-plugin-media-capture: 0.3.1 (70cd9a0ee3)
> cordova-plugin-network-information: 0.2.9 (be5875f9d9)
>
> cordova-plugin-splashscreen: 0.3.1 (b3b7a561ab)
> cordova-plugin-statusbar: 0.1.6 (11195658af)
> cordova-plugin-vibration: 0.3.9 (b2fdbc1c92)
> I am getting failing tests for contacts + battery. I have decided not
> to release them until they get reviewed.
>
> Upon a successful vote I will upload the archives to dist/, upload
> them to the Plugins Registry, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 72 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ensured tests were passing on iOS & Android by using createmobilespec
> script
> * Ran coho verify-tags with above output succssfully
>