You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Lars Francke <la...@gmail.com> on 2014/08/06 01:15:22 UTC
Review requests & JIRA process
Hi everyone,
I have a couple of review requests that I'd love for someone to look at.
I'll list them below. I have however two more questions.
Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). I
realize that they don't bring immediate benefit and I had planned to fix
some more of the issues Checkstyle, my IDE and SonarQube[1] complain about.
Is this okay for you guys or would you rather I stop this? I ask because
they take a significant amount of time not only for myself but also for a
reviewer and they go stale fast. I think it helps to have a clean codebase
for what it's worth.
The second question is about the JIRA process: What's the best way to get
someone to review patches? I currently always create a review, attach the
patch to the Issue and set it to PATCH AVAILABLE. The documentation is not
quite clear about the process[2].
These are the issues in need of reviews:
* <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
appreciate an answer fast to avoid having to rebase it often)
* <https://issues.apache.org/jira/browse/HIVE-7543>
* <https://issues.apache.org/jira/browse/HIVE-6123>
* <https://issues.apache.org/jira/browse/HIVE-7107>
Thanks!
Cheers,
Lars
[1] <http://www.sonarqube.org/> I have a publicly accessible server set up
with Hive analyzed, happy to send the link to anyone interested
http://i.imgur.com/e3KjR26.png
[2] <
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges
>
Re: Review requests & JIRA process
Posted by Lars Francke <la...@gmail.com>.
Thanks Sergey,
unfortunately it's often not easy to figure that out but I'll try.
So, anyone willing to do reviews on these:
These are the issues in need of reviews:
* <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
appreciate an answer fast to avoid having to rebase it often)
* <https://issues.apache.org/jira/browse/HIVE-7543> (relatively large)
* <https://issues.apache.org/jira/browse/HIVE-6123> (tiny)
* <https://issues.apache.org/jira/browse/HIVE-7107> (small)
About HIVE-7622: I realize that these huge patches are annoying but I hope
that they aren't required that often. The alternative are hundreds of small
issues/patches like <https://issues.apache.org/jira/browse/HIVE-7760> etc.
Not sure what you'd prefer.
Cheers,
Lars
On Thu, Aug 7, 2014 at 11:49 PM, Sergey Shelukhin <se...@hortonworks.com>
wrote:
> I think the process that works best for getting patches reviewed is adding
> specific people to RB/JIRA and asking, usually the people who are active in
> a related area of code. And nagging them until they either review or refuse
> to review :)
>
>
> On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke <la...@gmail.com>
> wrote:
>
> > Hey,
> >
> > just wanted to bump this in case anyone has any opinions as well as what
> > the procedure is for patches that don't get a review for a longer period
> of
> > time. I'd like to avoid a lot of unnecessary work on my end :)
> >
> > Cheers,
> > Lars
> >
> >
> > On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke <la...@gmail.com>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > I have a couple of review requests that I'd love for someone to look
> at.
> > > I'll list them below. I have however two more questions.
> > >
> > > Two of my issues are clean ups of existing code (HIVE-7622 &
> HIVE-7543).
> > I
> > > realize that they don't bring immediate benefit and I had planned to
> fix
> > > some more of the issues Checkstyle, my IDE and SonarQube[1] complain
> > about.
> > > Is this okay for you guys or would you rather I stop this? I ask
> because
> > > they take a significant amount of time not only for myself but also
> for a
> > > reviewer and they go stale fast. I think it helps to have a clean
> > codebase
> > > for what it's worth.
> > >
> > > The second question is about the JIRA process: What's the best way to
> get
> > > someone to review patches? I currently always create a review, attach
> the
> > > patch to the Issue and set it to PATCH AVAILABLE. The documentation is
> > not
> > > quite clear about the process[2].
> > >
> > > These are the issues in need of reviews:
> > >
> > > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
> > > appreciate an answer fast to avoid having to rebase it often)
> > > * <https://issues.apache.org/jira/browse/HIVE-7543>
> > > * <https://issues.apache.org/jira/browse/HIVE-6123>
> > > * <https://issues.apache.org/jira/browse/HIVE-7107>
> > >
> > > Thanks!
> > >
> > > Cheers,
> > > Lars
> > >
> > > [1] <http://www.sonarqube.org/> I have a publicly accessible server
> set
> > > up with Hive analyzed, happy to send the link to anyone interested
> > > http://i.imgur.com/e3KjR26.png
> > >
> > > [2] <
> > >
> >
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges
> > > >
> > >
> >
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
Re: Review requests & JIRA process
Posted by Sergey Shelukhin <se...@hortonworks.com>.
I think the process that works best for getting patches reviewed is adding
specific people to RB/JIRA and asking, usually the people who are active in
a related area of code. And nagging them until they either review or refuse
to review :)
On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke <la...@gmail.com> wrote:
> Hey,
>
> just wanted to bump this in case anyone has any opinions as well as what
> the procedure is for patches that don't get a review for a longer period of
> time. I'd like to avoid a lot of unnecessary work on my end :)
>
> Cheers,
> Lars
>
>
> On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke <la...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > I have a couple of review requests that I'd love for someone to look at.
> > I'll list them below. I have however two more questions.
> >
> > Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543).
> I
> > realize that they don't bring immediate benefit and I had planned to fix
> > some more of the issues Checkstyle, my IDE and SonarQube[1] complain
> about.
> > Is this okay for you guys or would you rather I stop this? I ask because
> > they take a significant amount of time not only for myself but also for a
> > reviewer and they go stale fast. I think it helps to have a clean
> codebase
> > for what it's worth.
> >
> > The second question is about the JIRA process: What's the best way to get
> > someone to review patches? I currently always create a review, attach the
> > patch to the Issue and set it to PATCH AVAILABLE. The documentation is
> not
> > quite clear about the process[2].
> >
> > These are the issues in need of reviews:
> >
> > * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
> > appreciate an answer fast to avoid having to rebase it often)
> > * <https://issues.apache.org/jira/browse/HIVE-7543>
> > * <https://issues.apache.org/jira/browse/HIVE-6123>
> > * <https://issues.apache.org/jira/browse/HIVE-7107>
> >
> > Thanks!
> >
> > Cheers,
> > Lars
> >
> > [1] <http://www.sonarqube.org/> I have a publicly accessible server set
> > up with Hive analyzed, happy to send the link to anyone interested
> > http://i.imgur.com/e3KjR26.png
> >
> > [2] <
> >
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges
> > >
> >
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Review requests & JIRA process
Posted by Lars Francke <la...@gmail.com>.
Hey,
just wanted to bump this in case anyone has any opinions as well as what
the procedure is for patches that don't get a review for a longer period of
time. I'd like to avoid a lot of unnecessary work on my end :)
Cheers,
Lars
On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke <la...@gmail.com> wrote:
> Hi everyone,
>
> I have a couple of review requests that I'd love for someone to look at.
> I'll list them below. I have however two more questions.
>
> Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). I
> realize that they don't bring immediate benefit and I had planned to fix
> some more of the issues Checkstyle, my IDE and SonarQube[1] complain about.
> Is this okay for you guys or would you rather I stop this? I ask because
> they take a significant amount of time not only for myself but also for a
> reviewer and they go stale fast. I think it helps to have a clean codebase
> for what it's worth.
>
> The second question is about the JIRA process: What's the best way to get
> someone to review patches? I currently always create a review, attach the
> patch to the Issue and set it to PATCH AVAILABLE. The documentation is not
> quite clear about the process[2].
>
> These are the issues in need of reviews:
>
> * <https://issues.apache.org/jira/browse/HIVE-7622> (huge but I'd
> appreciate an answer fast to avoid having to rebase it often)
> * <https://issues.apache.org/jira/browse/HIVE-7543>
> * <https://issues.apache.org/jira/browse/HIVE-6123>
> * <https://issues.apache.org/jira/browse/HIVE-7107>
>
> Thanks!
>
> Cheers,
> Lars
>
> [1] <http://www.sonarqube.org/> I have a publicly accessible server set
> up with Hive analyzed, happy to send the link to anyone interested
> http://i.imgur.com/e3KjR26.png
>
> [2] <
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-MakingChanges
> >
>