You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/10/10 01:21:32 UTC
[GitHub] [incubator-pegasus] liangyuanpeng opened a new issue, #1165: Provide container image for pegasus
liangyuanpeng opened a new issue, #1165:
URL: https://github.com/apache/incubator-pegasus/issues/1165
## Feature Request
**Is your feature request related to a problem? Please describe:**
I had try to use github action to build pegasus and it in standalone action, considering that we already have a [nightly github action for build](https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/regular-build.yml), it would be great if it could be include build and push docker image.
Unfortunately, it's running in a container, and I try to mount the host's docker command, which doesn't seem to work.
Some like that:
```yaml
container:
image: apache/pegasus:thirdparties-bin-${{ matrix.os }}-master
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- /usr/bin/docker:/usr/bin/docker
```
Whether to consider using github action machine instead of container to build pegasus.
/cc @acelyc111
**Describe the feature you'd like:**
Container image of pegasus.
**Describe alternatives you've considered:**
**Teachability, Documentation, Adoption, Migration Strategy:**
1. User must compile pegasus if they want to use pegasus, provide a container image of pegasus can run pegasus quick.
2. Use pegasus container instead of compile pegasus to run CI for client code. This can greatly improve efficiency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1165: Provide container image for pegasus
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1165:
URL: https://github.com/apache/incubator-pegasus/issues/1165#issuecomment-1253239837
@liangyuanpeng Thanks for your advice, it's reasonable. Pegasus has a docker compose solution[1], however, it's also needed to build it manually at first.
Could you help to do this work that push built Pegasus images to DockerHub?
1. https://github.com/apache/incubator-pegasus/tree/master/docker/pegasus-docker-compose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] liangyuanpeng commented on issue #1165: Provide container image for pegasus
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on issue #1165:
URL: https://github.com/apache/incubator-pegasus/issues/1165#issuecomment-1272562687
This issue mean want to a image what can run, it isn't the problem about doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] liangyuanpeng commented on issue #1165: Provide container image for pegasus
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on issue #1165:
URL: https://github.com/apache/incubator-pegasus/issues/1165#issuecomment-1257199331
Absolutely, so i would change build pegasus to use command of `docker run apache/pegasus:build-env-xxxx /bin/bash -c "./run.sh build xxx" ` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1165: Provide container image for pegasus
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1165:
URL: https://github.com/apache/incubator-pegasus/issues/1165#issuecomment-1272523446
I have updated the build docs for the master banch, see https://pegasus.apache.org/docs/build/compile-by-docker/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed issue #1165: Provide container image for pegasus
Posted by GitBox <gi...@apache.org>.
acelyc111 closed issue #1165: Provide container image for pegasus
URL: https://github.com/apache/incubator-pegasus/issues/1165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org