[GitHub] [flink] Myasuka commented on a change in pull request #10921: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #10921: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369644740
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
 ##########
 @@ -71,12 +74,26 @@
 
 	protected abstract B getStateBackend() throws Exception;
 
+	protected abstract long getManagedMemorySize();
 
 Review comment:
   The original `MockEnvironmentBuilder` would already have a default `memorySize` as `1024 * 32 * 1024`. The reason I introduced a `getManagedMemorySize` method here is to let non-RocksDB test could not reserve any off-heap memory.
   If you agree, I think we could use original `MockEnvironmentBuilder` directly but also reserve off-heap memory for non-RocksDB tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services