[jira] [Updated] (WICKET-4353) Choice is not rendered as selected on different instances semantically equal

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier updated WICKET-4353:
-------------------------------

    Attachment: WICKET-4353-IChoiceRenderer-Without-Index.diff

I've tried out an IChoiceRenderer without index parameter, see diff.

Still supports index-based values for options (although slower), works out nicely for the Palette component *but* might still not be worth it.

@Igor WDYT?
                
> Choice is not rendered as selected on different instances semantically equal
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-4353
>                 URL: https://issues.apache.org/jira/browse/WICKET-4353
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.4
>         Environment: windows, jdk1.6
>            Reporter: Per Newgro
>            Assignee: Sven Meier
>              Labels: DropDownChoice
>             Fix For: 1.5.7
>
>         Attachments: WICKET-4353-IChoiceRenderer-Without-Index.diff, ddcbug.zip
>
>
> With 1.5.4 there was a change in org.apache.wicket.markup.html.form.AbstractSingleSelectChoice.java
> Sven stated in list that: "Igor's commit statements says "improved inconsistency handling in choice components".
> This change prevents IChoiceRenderer#getIdValue() being called with -1 as the index argument. ".
> It is defenitly a comprehensible change. But the effect is (for me) quite heavy.
> If you don't overwrite equals in selectable objects then two semantically equal instances will not be rendered as 
> selected because of the different physical instances. But it worked in 1.5.3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira