You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 16:53:10 UTC

svn commit: r1775503 - /jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java

Author: pmouawad
Date: Wed Dec 21 16:53:10 2016
New Revision: 1775503

URL: http://svn.apache.org/viewvc?rev=1775503&view=rev
Log:
Sonar : Fix code smells

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java?rev=1775503&r1=1775502&r2=1775503&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java Wed Dec 21 16:53:10 2016
@@ -70,7 +70,10 @@ public class UserParametersGui extends A
 
     private int numUserColumns = 1;
 
-    private JButton addParameterButton, addUserButton, deleteRowButton, deleteColumnButton;
+    private JButton addParameterButton;
+    private JButton addUserButton;
+    private JButton deleteRowButton;
+    private JButton deleteColumnButton;
 
     private JCheckBox perIterationCheck;
 
@@ -128,7 +131,7 @@ public class UserParametersGui extends A
     @Override
     public void modifyTestElement(TestElement params) {
         GuiUtils.stopTableEditing(paramTable);
-        UserParameters userParams = ((UserParameters) params);
+        UserParameters userParams = (UserParameters) params;
         userParams.setNames(new CollectionProperty(UserParameters.NAMES, tableModel.getColumnData(NAME_COL_RESOURCE)));
         CollectionProperty threadLists = new CollectionProperty(UserParameters.THREAD_VALUES, new ArrayList<>());
         log.debug("making threadlists from gui");
@@ -198,13 +201,8 @@ public class UserParametersGui extends A
         JLabel tableLabel = new JLabel(JMeterUtils.getResString("user_parameters_table")); // $NON-NLS-1$
         initTableModel();
         paramTable = new JTable(tableModel);
-        // paramTable.setRowSelectionAllowed(true);
-        // paramTable.setColumnSelectionAllowed(true);
         paramTable.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
         paramTable.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
-        // paramTable.setCellSelectionEnabled(true);
-        // paramTable.setPreferredScrollableViewportSize(new Dimension(100,
-        // 70));
         JMeterUtils.applyHiDPI(paramTable);
 
         paramPanel = new JPanel(new BorderLayout());