You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2007/08/29 15:26:00 UTC

svn commit: r570804 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java

Author: jcompagner
Date: Wed Aug 29 06:26:00 2007
New Revision: 570804

URL: http://svn.apache.org/viewvc?rev=570804&view=rev
Log:
call detach in checkReuse else it keeps hanging

Modified:
    wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java

Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java?rev=570804&r1=570803&r2=570804&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/RequestCycle.java Wed Aug 29 06:26:00 2007
@@ -873,6 +873,7 @@
 	{
 		if (currentStep != NOT_STARTED)
 		{
+			detach();
 			throw new WicketRuntimeException(
 					"RequestCycles are non-reusable objects. This instance (" + this +
 							") already executed");
@@ -1204,7 +1205,14 @@
 		// Detach from session
 		if (sessionExists())
 		{
-			getSession().detach();
+			try
+			{
+				getSession().detach();
+			}
+			catch (RuntimeException re)
+			{
+				log.error("there was an error detaching the session", re);
+			}
 		}
 
 		if (isRedirect())