You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ngrewe <gi...@git.apache.org> on 2016/02/26 16:48:23 UTC
[GitHub] thrift pull request: Thrift 3676
GitHub user ngrewe opened a pull request:
https://github.com/apache/thrift/pull/896
Thrift 3676
This PR adds proper error handling to the generated Cocoa server implementations. To find which err property in the result object we need to set the error to, we check have to check the type of the error at runtime, which is a consequence of using NSError** arguments to pass things around.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngrewe/thrift THRIFT-3676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #896
----
commit aee624013ee5674846cd3bcc7bd4726738d2c45c
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-25T16:48:07Z
Emit an exception in the failure case
commit 77924bbff3b21deeff63b1d8550c578b0a03e95b
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-25T18:58:12Z
Handle explicit exceptions as well
commit 393ed79e84dc7bd2703cd40c93191fb078c18d2b
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-25T19:01:45Z
Tweak
commit 5524fd0d0a48514fd08b8acaf4180eafec10c78b
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-25T19:13:15Z
Fix emitting exceptions
commit 0483c93ddc8e00da3ec7b5f2217ff32d1c4bba9f
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-26T07:56:09Z
Application errors should not be propagated as processing errors
commit 284d2551d48e0ef45e90157e8bf6468b6354711d
Author: Niels Grewe <ni...@halbordnung.de>
Date: 2016-02-26T15:04:59Z
Clarify variable name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #896: THRIFT-3676
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/896
---
[GitHub] thrift issue #896: THRIFT-3676
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/896
I think this should be closed and resubmitted, the history got messed up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #896: THRIFT-3676
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/896
Hi, would you be able to rebase on the current master and squash the commits, and force push? This will restart the CI build with our current codebase so we know the change is still applicable and passes all tests. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---