You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/10/08 12:31:16 UTC
[PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
elharo opened a new pull request, #493:
URL: https://github.com/apache/commons-io/pull/493
Something very weird happened with the previous iteration of this PR. This PR should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #493:
URL: https://github.com/apache/commons-io/pull/493#issuecomment-1752020576
Hi @elharo
You can run `mvn` from a command shell to catch these build errors. `mvn` runs our default goal which includes all the checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #493:
URL: https://github.com/apache/commons-io/pull/493#issuecomment-1752023125
mvn test doesn't catch checkstyle errors. I have to look for those specifically.
On the previous iteration, the CI passed on my PR. The code was somehow modified after I submitted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #493:
URL: https://github.com/apache/commons-io/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #493:
URL: https://github.com/apache/commons-io/pull/493#issuecomment-1752029991
> mvn test doesn't catch checkstyle errors. I have to look for those specifically.
>
> On the previous iteration, the CI passed on my PR. The code was somehow modified after I submitted it.
No you don't, as noted above, run `mvn`, by itself, this causes the default Maven goal to run, which includes all of the checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #493:
URL: https://github.com/apache/commons-io/pull/493#issuecomment-1752030553
Side note: In general, don't edit `changes.xml` in PRs, this usually causes conflicts if another PR also edits that file or if, invariably, that file has been edited in the course of plain old development.
As an alternative, we could use Log4j's change log mechanism which avoids any and all conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IO-414] Don't write a BOM on every (or any) line [commons-io]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #493:
URL: https://github.com/apache/commons-io/pull/493#issuecomment-1752017916
## [Codecov](https://app.codecov.io/gh/apache/commons-io/pull/493?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#493](https://app.codecov.io/gh/apache/commons-io/pull/493?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4c3b20e) into [master](https://app.codecov.io/gh/apache/commons-io/commit/43594ce6f5d5286677233442bf06b68a67874c3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (43594ce) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #493 +/- ##
============================================
- Coverage 84.97% 84.96% -0.02%
Complexity 3372 3372
============================================
Files 227 227
Lines 8080 8081 +1
Branches 953 954 +1
============================================
Hits 6866 6866
Misses 960 960
- Partials 254 255 +1
```
| [Files](https://app.codecov.io/gh/apache/commons-io/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/main/java/org/apache/commons/io/IOUtils.java](https://app.codecov.io/gh/apache/commons-io/pull/493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vSU9VdGlscy5qYXZh) | `86.78% <100.00%> (+0.02%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/commons-io/pull/493/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org