You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/20 14:38:57 UTC
[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #20: Support GitHub Action
mrproliu opened a new pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20
* Support Github Action
* Fix exit code is not `1` bug when verify failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947128
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
Review comment:
Should we run this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947942
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
please use `/home/skywalking-infra-e2e`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654951191
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
How SkyWalking eye works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654949251
##########
File path: action.yaml
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p /home/e2e/bin
Review comment:
see https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947942 please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654950165
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
I have tried using an absolute path on this, but the GHA composite mode is not supported. please see: https://github.com/mrproliu/skywalking/pull/1/checks?check_run_id=2869437957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654951940
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
> GHA doesn't download the code base automatically?
Using the `composite` type GHA, it doesn't download the code automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654949613
##########
File path: action.yaml
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p /home/e2e/bin
+ - shell: bash
+ run: |
+ cd /home/e2e
+ git clone https://github.com/apache/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
+ cd skywalking-infra-e2e
+ go mod download && make linux && mv bin/linux/e2e ../bin/e2e
+ - shell: bash
+ run: |
+ cd /home/e2e
+ git clone https://github.com/apache/skywalking-cli.git
+ git -C skywalking-cli reset --hard 21ba64dd2ddfd6cfeca14801e7c3888f1befc3ca
+ cd skywalking-cli
+ make build && mv bin/swctl-*-linux-amd64 ../bin/swctl
+ - shell: bash
+ run: |
+ pwd=`pwd`
+ export PATH="$PATH:/home/e2e/bin"
+ cd $pwd
+ e2e run -c "${{ inputs.e2e-file }}"
Review comment:
```suggestion
export PATH="$PATH:/home/e2e/bin"
e2e run -c "${{ inputs.e2e-file }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947414
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
Review comment:
This is not a task, it's the definition of our GHA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947679
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
> Let's use an absolute path, for example, `/home/e2e`
Otherwise, it may pollute the users workspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654952739
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
There is a dilemma here, the SHA will be changed when we squash and merge, let me see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654951507
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
GHA doesn't download the code base automatically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 merged pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654950165
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
I have tried using an absolute path on this, but the GHA composite mode is not supported. please see https://github.com/mrproliu/skywalking/pull/1/checks?check_run_id=2869437957. I'm trying to use `/tmp` as root, please wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654945878
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
Review comment:
```suggestion
git clone https://github.com/apache/skywalking-infra-e2e.git
```
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
+ cd skywalking-infra-e2e
+ go mod download && make linux && mv bin/linux/e2e ../bin/e2e
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/apache/skywalking-cli.git
+ git -C skywalking-cli reset --hard 21ba64dd2ddfd6cfeca14801e7c3888f1befc3ca
+ cd skywalking-cli
+ make build && mv bin/swctl-*-linux-amd64 ../bin/swctl
+ - shell: bash
+ run: |
+ cd skywalking-e2e/bin
+ pwd=`pwd`
+ export PATH="$PATH:$pwd"
Review comment:
```suggestion
export PATH="$PATH:$(pwd)"
```
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
+ - shell: bash
+ run: |
+ cd skywalking-e2e
+ git clone https://github.com/mrproliu/skywalking-infra-e2e.git
+ git -C skywalking-infra-e2e reset --hard 4fb6aef3f84b8d19bc38c75e4e4489d7ce1d8d71
Review comment:
Did you find any clue about how to get the revision if a user specify it in `uses: apache/skywalking-infra-e2e@main`, for example, get the `v1.0` in `uses: apache/skywalking-infra-e2e@v1.0`?
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
Let's use an absolute path, for example, `/home/e2e`
##########
File path: test/verify/3.expected.yaml
##########
@@ -15,8 +15,10 @@
# specific language governing permissions and limitations
# under the License.
-{{- contains . }}
-- id: {{ notEmpty .id }}
- name: {{ notEmpty .name }}
+{{if . }}
+- id: { { notEmpty .id } }
+ name: { { notEmpty .name } }
Review comment:
this is syntax error I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654947942
##########
File path: action.yaml
##########
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: SkyWalking Infra E2E
+description: End-to-End Tesing framework that help to set up, verify E2E tests.
+author: Apache SkyWalking
+inputs:
+ e2e-file:
+ description: File path of e2e file
+ required: true
+
+runs:
+ using: "composite"
+ steps:
+ - shell: bash
+ run: |
+ mkdir -p skywalking-e2e/bin
Review comment:
please use `/home/skywalking-e2e`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #20: Support GitHub Action
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #20:
URL: https://github.com/apache/skywalking-infra-e2e/pull/20#issuecomment-864571184
> [#20 (comment)](https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654945907) may not be an quick thing to do, so feel free to merge and consider it later, thanks very much for doing this 👍🏻
Sorry for dismisses your approval, I need to do a little recheck. The https://github.com/apache/skywalking-infra-e2e/pull/20#discussion_r654945907 I will check if GHA has the variable after this PR merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org