You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:54:13 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #1477: Flink: maintain the complete data files into manifest before checkpoint finished.

stevenzwu commented on pull request #1477:
URL: https://github.com/apache/iceberg/pull/1477#issuecomment-708563244


   This looks good to me.
   
   I am wondering if we should define `FlinkManifestFile` impl and provide a state serializer for it. right now, we pass in byte[] type to Flink state. We probably need to change this once we move to the new FLIP-143 sink interface, which will require a GlobalCommT and a serializer for it. So I am saying we can postpone the work until then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org