You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Okomin (JIRA)" <ji...@apache.org> on 2006/08/15 16:49:15 UTC
[jira] Created: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
[classlib][internationalization]Sources to support internationalization are to be generated.
--------------------------------------------------------------------------------------------
Key: HARMONY-1201
URL: http://issues.apache.org/jira/browse/HARMONY-1201
Project: Harmony
Issue Type: Sub-task
Components: Classlib
Reporter: Ilya Okomin
Priority: Minor
There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
These files are:
Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
Read for details in [1] and [2].
There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
[1] http://issues.apache.org/jira/browse/HARMONY-1041
[2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=comments#action_12429097 ]
Tim Ellison commented on HARMONY-1201:
--------------------------------------
Ok, I had a chance to look at the new patch:
- seems like we need to include the nio_char and x-net modules too. The package names would be o.a.h.niochar.i.n and ...xnet... respectively.
- we don't have a module called 'net' yet the tool has created an nls package for it
- in the modified build.xml I would suggest that the copy.resources is a dependency of the 'build' target, not the 'compile.java' (i.e. we need to copy the resoures to achive a build, but we don't need to copy the resources to compile the java).
let me know if you agree.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Tim Ellison resolved HARMONY-1201.
----------------------------------
Resolution: Fixed
Thanks for your patience Ilya.
Patch applied at repo revision r437854.
Please check that it was applied as you expected.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: intern.diff, Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=comments#action_12429385 ]
Ilya Okomin commented on HARMONY-1201:
--------------------------------------
Tim, I've took a look at your comments:
1. As for nio_char and x-net. I have no objections to make small work around for these modules. Just a couple of questions: Are they planned to be renamed in the nearest future? Do we have a policy of modules naming?
2. As a continuation of non-existent 'net' module, would you be so kind to show me resources, where I can find out which modules exist now?
It would be great to know that to define list of modules for internationalization and to update resources on time when new modules are about to come.
3. I totally agree with you, that 'copy.resources' logically related to the 'build' target. In my patch I used scheme that was presented in 'sql' module, because it was already committed and it worked.
I'm going to make changes to the patch and msgstool according to your comments.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Ilya Okomin updated HARMONY-1201:
---------------------------------
Attachment: Internationalization_support_sources.patch
There are sources for the set of modules:
module.00=luni
module.01=security
module.03=auth
module.04=awt
module.05=nio
module.06=prefs
module.07=regex
module.08=rmi
module.09=security
module.0A=sql
module.0B=swing
module.0C=text
module.0D=net
module.0E=math
module.OF=misc
module.10=annotation
module.11=applet
module.12=archive
module.13=beans
module.14=crypto
module.15=jndi
module.16=logging
module.17=accessibility
module.18=instrument
module.19=sound
module.1A=tools
Also made fixes for <module>\build.xml and <module>\make\patternset.txt files.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Priority: Minor
> Attachments: Internationalization_support_sources.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=comments#action_12431194 ]
Ilya Okomin commented on HARMONY-1201:
--------------------------------------
Thanks, Tim!
Everything looks fine. It is exactly what I've expected.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: intern.diff, Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Tim Ellison closed HARMONY-1201.
--------------------------------
Verified by Ilya.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: intern.diff, Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Ilya Okomin updated HARMONY-1201:
---------------------------------
Attachment: intern.diff
Updated patch:
1. added 'x-net' and 'nio_char' modules support
2. 'copy.resources' target dependency changed from 'compile.java' to 'build' target.
Note:
- in 'sql' module there was already 'copy.resources' target (exactly for internationalization needs) - dependency has been changed;
- in 'logging' module there was also 'copy.resources' target to copy 'logging.properties' file to the {build}/jre/lib folder, for this reason new one 'copy.jar.resources' target to copy internationalization resources has been created.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: intern.diff, Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=comments#action_12428692 ]
Tim Ellison commented on HARMONY-1201:
--------------------------------------
Ilya -- the patch appears to contain two copies of the Messages.java file for each module, and therefore does not apply cleanly.
Can you take a look and see if it works for you?
Thanks
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Priority: Minor
> Attachments: Internationalization_support_sources.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Tim Ellison reassigned HARMONY-1201:
------------------------------------
Assignee: Tim Ellison
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: Internationalization_support_sources.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1201)
[classlib][internationalization]Sources to support internationalization are
to be generated.
Posted by "Ilya Okomin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1201?page=all ]
Ilya Okomin updated HARMONY-1201:
---------------------------------
Attachment: Internationalization_support_sources_fix.patch
Tim, I was confused to see dublicated source files in the patch.
I used TortoiseSVN tool to create patch. AFAIU both files and folders were chosen there to be created in the patch, for this reason folders contents (already chosen files) were added once more.
I've fixed patch for you, hope this time everything is ok. I've applied it to the Harmony/modules (this patch is for the modules folder) and build Harmony - everything is ok.
You can find, that in several build configuration files tabs were replaced by spaces, I think it's ok.
> [classlib][internationalization]Sources to support internationalization are to be generated.
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-1201
> URL: http://issues.apache.org/jira/browse/HARMONY-1201
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Ilya Okomin
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: Internationalization_support_sources.patch, Internationalization_support_sources_fix.patch
>
>
> There is a necessity to generate source class files and resources to support internationalization in Harmony for each module.
> These files are:
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal/nls/Messages.java
> Harmony/modules/<module>/src/main/java/[common/]org/apache/harmony/<module>/internal.nls/messages.properties
> Read for details in [1] and [2].
> There is also a necessity to fix build configuration files to add resources to the jars during Harmony build.
> [1] http://issues.apache.org/jira/browse/HARMONY-1041
> [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200608.mbox/%3cc79906b30608020145h79cbb991l830db1f56c49ddda@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira