You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2012/04/16 23:45:14 UTC
Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/
-----------------------------------------------------------
Review request for qpid and Gordon Sim.
Summary
-------
The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
/trunk/qpid/cpp/src/tests/ha_tests.py 1326757
Diff: https://reviews.apache.org/r/4744/diff
Testing
-------
make check
Thanks,
Alan
Re: Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/#review6971
-----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/4744/#comment15525>
I think the incrementing of the consumer count should perhaps be within the if statement above. Otherwise the enforcement of the exclusive flag depends on order of subscriptions. I.e. if a browser subscribes first, then an exclusive consume request will fail whereas if the exclusive consumer subscribes first, the browser will be allowed to subscribe without error.
- Gordon
On 2012-04-16 21:45:14, Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 21:45:14)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Summary
> -------
>
> The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
> /trunk/qpid/cpp/src/tests/ha_tests.py 1326757
>
> Diff: https://reviews.apache.org/r/4744/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alan
>
>
Re: Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/#review6976
-----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/4744/#comment15530>
Agreed
- Alan
On 2012-04-16 21:45:14, Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 21:45:14)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Summary
> -------
>
> The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
> /trunk/qpid/cpp/src/tests/ha_tests.py 1326757
>
> Diff: https://reviews.apache.org/r/4744/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alan
>
>
Re: Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/#review6977
-----------------------------------------------------------
Ship it!
- Gordon
On 2012-04-17 14:06:06, Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4744/
> -----------------------------------------------------------
>
> (Updated 2012-04-17 14:06:06)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Summary
> -------
>
> The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Queue.h 1326757
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
> /trunk/qpid/cpp/src/tests/ha_tests.py 1326757
>
> Diff: https://reviews.apache.org/r/4744/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alan
>
>
Re: Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/
-----------------------------------------------------------
(Updated 2012-04-17 14:10:00.079350)
Review request for qpid and Gordon Sim.
Summary
-------
The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
Diffs (updated)
-----
/trunk/qpid/cpp/src/qpid/broker/Queue.h 1326757
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
/trunk/qpid/cpp/src/tests/ha_tests.py 1326757
Diff: https://reviews.apache.org/r/4744/diff
Testing
-------
make check
Thanks,
Alan
Re: Review Request: QPID-3950: Allow browsing of queues with exclusive
subscriptions
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4744/
-----------------------------------------------------------
(Updated 2012-04-17 14:06:06.547347)
Review request for qpid and Gordon Sim.
Changes
-------
Update: Keep track of browser (non-acquiring consumers) count as well so we can accurately apply exclusion to acquiring consumers only.
Summary
-------
The C++ broker already allows browsing subscriptons to exclusive queues. To be consistent we need to extend this to queues with exclusive subscritions as well. This is required by the new HA plugin (QPID-3603) so that replicating subscriptions can browse from exclusive queues in order to replicate their messages to a backup broker.
Diffs (updated)
-----
/trunk/qpid/cpp/src/qpid/broker/Queue.h 1326757
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1326757
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1326757
/trunk/qpid/cpp/src/tests/ha_tests.py 1326757
Diff: https://reviews.apache.org/r/4744/diff
Testing
-------
make check
Thanks,
Alan