[GitHub] [hudi] 5herhom commented on a diff in pull request #6254: [HUDI-4508] Repair the exception when reading optimized query for mor in hive and presto/trino

[GitBox <gi...@apache.org>]

5herhom commented on code in PR #6254:
URL: https://github.com/apache/hudi/pull/6254#discussion_r933926646


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieMergeOnReadTableInputFormat.java:
##########
@@ -85,7 +85,7 @@ public InputSplit[] getSplits(JobConf job, int numSplits) throws IOException {
   }
 
   @Override
-  protected FileStatus createFileStatusUnchecked(FileSlice fileSlice, HiveHoodieTableFileIndex fileIndex, Option<HoodieVirtualKeyInfo> virtualKeyInfoOpt) {
+  protected Option<? extends FileStatus> createFileStatusUnchecked(FileSlice fileSlice, HiveHoodieTableFileIndex fileIndex, Option<HoodieVirtualKeyInfo> virtualKeyInfoOpt) {

Review Comment:
   To be compatible with HoodieCopyOnWriteTableInputFormat.createFileStatusUnchecked()，wrap the return with optional



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org