[GitHub] [beam] aromanenko-dev commented on a diff in pull request #25263: [Spark runner] Removal of Spark 2 runner support

["aromanenko-dev (via GitHub)" <gi...@apache.org>]

aromanenko-dev commented on code in PR #25263:
URL: https://github.com/apache/beam/pull/25263#discussion_r1097253743


##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1535,9 +1535,8 @@ def _add_argparse_args(cls, parser):
     parser.add_argument(
         '--spark_version',
         default='3',
-        choices=['3', '2'],
-        help='Spark major version to use. '
-        'Note, Spark 2 support is deprecated')
+        choices=['3'],

Review Comment:
   Do you keep it for future Spark versions, like `Spark 4`?



##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -730,8 +729,6 @@ class BeamModulePlugin implements Plugin<Project> {
         slf4j_jcl                                   : "org.slf4j:slf4j-jcl:$slf4j_version",
         snappy_java                                 : "org.xerial.snappy:snappy-java:1.1.8.4",
         spark_core                                  : "org.apache.spark:spark-core_2.11:$spark2_version",

Review Comment:
   Should this line and a one with `spark_streaming` below be removed as well?



##########
sdks/python/apache_beam/runners/portability/spark_runner.py:
##########
@@ -93,9 +93,7 @@ def path_to_jar(self):
       return self._jar
     else:
       if self._spark_version == '2':

Review Comment:
   Why we still need this check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org