You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zhitao Li <zh...@gmail.com> on 2016/01/12 03:34:32 UTC
Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Bugs: AURORA-1109
https://issues.apache.org/jira/browse/AURORA-1109
Repository: aurora
Description
-------
This is how I tested changes in https://reviews.apache.org/r/42176/.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
Diff: https://reviews.apache.org/r/42177/diff/
Testing
-------
Integration test script.
Thanks,
Zhitao Li
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review113921
-----------------------------------------------------------
Ship it!
Master (f064dc1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 12, 2016, 2:34 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 2:34 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > <https://reviews.apache.org/r/42177/diff/1/?file=1192902#file1192902line27>
> >
> > Is this really needed? All logs are currently dumped under /var/log/upstart if I remember it right.
>
> Zhitao Li wrote:
> You are indeed right. I added this before findout out Mesos logs is in the other location. I'll rebase this review request and remove this log line change.
>
> This review mostly exists to show how I performed integration tests when working on previous diff. If anyone feels that we do not want to change the default mode of integration test, I don't feel strong to check this in anyway.
>
> Bill Farner wrote:
> I'm a big proponent of having this covered in the integration tests, so I'm happy to see this patch.
+1.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
-----------------------------------------------------------
On Jan. 19, 2016, 6:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 6:46 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 8120ff7706f0ad0810ec9018c55d0d065066cbc5
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 19, 2016, 10:39 a.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > <https://reviews.apache.org/r/42177/diff/1/?file=1192902#file1192902line27>
> >
> > Is this really needed? All logs are currently dumped under /var/log/upstart if I remember it right.
>
> Zhitao Li wrote:
> You are indeed right. I added this before findout out Mesos logs is in the other location. I'll rebase this review request and remove this log line change.
>
> This review mostly exists to show how I performed integration tests when working on previous diff. If anyone feels that we do not want to change the default mode of integration test, I don't feel strong to check this in anyway.
I'm a big proponent of having this covered in the integration tests, so I'm happy to see this patch.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
-----------------------------------------------------------
On Jan. 12, 2016, 8:04 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 8:04 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Zhitao Li <zh...@gmail.com>.
> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > <https://reviews.apache.org/r/42177/diff/1/?file=1192902#file1192902line27>
> >
> > Is this really needed? All logs are currently dumped under /var/log/upstart if I remember it right.
You are indeed right. I added this before findout out Mesos logs is in the other location. I'll rebase this review request and remove this log line change.
This review mostly exists to show how I performed integration tests when working on previous diff. If anyone feels that we do not want to change the default mode of integration test, I don't feel strong to check this in anyway.
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
-----------------------------------------------------------
On Jan. 13, 2016, 4:04 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 4:04 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
-----------------------------------------------------------
examples/vagrant/upstart/mesos-master.conf (line 27)
<https://reviews.apache.org/r/42177/#comment176107>
Is this really needed? All logs are currently dumped under /var/log/upstart if I remember it right.
- Maxim Khutornenko
On Jan. 13, 2016, 4:04 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 4:04 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115210
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 19, 2016, 6:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 6:46 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 8120ff7706f0ad0810ec9018c55d0d065066cbc5
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115236
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 19, 2016, 10:46 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 10:46 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is how I tested changes in https://reviews.apache.org/r/42176/.
>
>
> Diffs
> -----
>
> examples/vagrant/upstart/aurora-scheduler.conf 8120ff7706f0ad0810ec9018c55d0d065066cbc5
> examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
> examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
>
> Diff: https://reviews.apache.org/r/42177/diff/
>
>
> Testing
> -------
>
> Integration test script.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 6:46 p.m.)
Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Changes
-------
Revert change to log location and rebase with master.
Bugs: AURORA-1109
https://issues.apache.org/jira/browse/AURORA-1109
Repository: aurora
Description
-------
This is how I tested changes in https://reviews.apache.org/r/42176/.
Diffs (updated)
-----
examples/vagrant/upstart/aurora-scheduler.conf 8120ff7706f0ad0810ec9018c55d0d065066cbc5
examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
Diff: https://reviews.apache.org/r/42177/diff/
Testing
-------
Integration test script.
Thanks,
Zhitao Li
Re: Review Request 42177: Vagrant change to reserve part of the dev
cluster's resources to 'aurora-role'
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 8:04 p.m.)
Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Changes
-------
Added formal review dep to ensure we don't try to commit this before the multi-role support patch.
-wfarner
Bugs: AURORA-1109
https://issues.apache.org/jira/browse/AURORA-1109
Repository: aurora
Description
-------
This is how I tested changes in https://reviews.apache.org/r/42176/.
Diffs
-----
examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275
examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379
examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359
Diff: https://reviews.apache.org/r/42177/diff/
Testing
-------
Integration test script.
Thanks,
Zhitao Li