[jira] [Commented] (DRILL-18) Parser has some breakage

["Ted Dunning (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530974#comment-13530974 ] 

Ted Dunning commented on DRILL-18:
----------------------------------

This patch doesn't apply cleanly.  I tried patch, patch -p 0 and git am.  None worked.  It seems that the diff has been trimmed a bit too much.

Please help by providing a patch produced using git format-patch or by using github to fork https://github.com/apache/incubator-drill/

                
> Parser has some breakage
> ------------------------
>
>                 Key: DRILL-18
>                 URL: https://issues.apache.org/jira/browse/DRILL-18
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Ted Dunning
>         Attachments: DRILL-18.patch
>
>
> Hi, I wrote some codes for query parser. These diffs are aimed to pass test
> case of query parser, especially org.apache.drill.parsers.DrqlParserTest.
> To do that, I modified the DrqlAntlr.g and AntlrParser.java.
> - Add some rules (N_AGGREGATE_FUNCTION, aggregateFunc, ... )
> - Swap groupbyClause rule and havingCaluse rule in selectStatement
> - Modify some parsing routine in AntlrParser.java
> I think that the defined grammar still has some problems even if this diff
> is applied. Also, it is not important thing. However, you can pass test
> case ;)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira