You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/14 07:20:37 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request #10762: Fix cardinality estimation
abhishekagarwal87 opened a new pull request #10762:
URL: https://github.com/apache/druid/pull/10762
This PR changes the logic to compute total number of output rows when automatically calculating numShards. Currently, we estimate the unique number of hash buckets as the cardinality. Instead, we would always consider the unique number of rows irrespective of the partition dimensions.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #10762: Fix cardinality estimation
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #10762:
URL: https://github.com/apache/druid/pull/10762#discussion_r564899614
##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -300,6 +300,20 @@ public DataSchema withTransformSpec(TransformSpec transformSpec)
);
}
+ public DataSchema withDimensionSpec(DimensionsSpec dimensionsSpec)
Review comment:
typo: `withDimensionsSpec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10762: Fix cardinality estimation
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10762:
URL: https://github.com/apache/druid/pull/10762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10762: Fix cardinality estimation
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on a change in pull request #10762:
URL: https://github.com/apache/druid/pull/10762#discussion_r565037290
##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -300,6 +300,20 @@ public DataSchema withTransformSpec(TransformSpec transformSpec)
);
}
+ public DataSchema withDimensionSpec(DimensionsSpec dimensionsSpec)
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org