You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Daniel Gómez Ferro (Created JIRA)" <ji...@apache.org> on 2012/03/14 13:52:38 UTC

[jira] [Created] (HBASE-5579) A Delete Version could mask other values

A Delete Version could mask other values
----------------------------------------

                 Key: HBASE-5579
                 URL: https://issues.apache.org/jira/browse/HBASE-5579
             Project: HBase
          Issue Type: Bug
            Reporter: Daniel Gómez Ferro


A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230450#comment-13230450 ] 

Daniel Gómez Ferro commented on HBASE-5579:
-------------------------------------------

It was messing a YCSB experiment where we do the initial load with TS = 0

We spent a good time trying to figure out who was removing data from our cluster!
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229812#comment-13229812 ] 

Lars Hofhansl commented on HBASE-5579:
--------------------------------------

Hmm... Shouldn't reset and isEmpty just set/check -1?
Like Ted I don't understand why 0 does not count anymore in the test.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230618#comment-13230618 ] 

Lars Hofhansl commented on HBASE-5579:
--------------------------------------

bq. This should go to 0.94, I assume

Yes. Want me to do it, Ted?
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230445#comment-13230445 ] 

stack commented on HBASE-5579:
------------------------------

+1 on patch

This was messing up bulk loaded data?

How did you figure it Daniel?  Nice digging.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230912#comment-13230912 ] 

Hudson commented on HBASE-5579:
-------------------------------

Integrated in HBase-TRUNK-security #139 (See [https://builds.apache.org/job/HBase-TRUNK-security/139/])
    HBASE-5579 A Delete Version could mask other values (Daniel Ferro) (Revision 1301173)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java

                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>            Assignee: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230661#comment-13230661 ] 

Hudson commented on HBASE-5579:
-------------------------------

Integrated in HBase-0.94 #33 (See [https://builds.apache.org/job/HBase-0.94/33/])
    HBASE-5579 A Delete Version could mask other values (Daniel Ferro) (Revision 1301240)

     Result = SUCCESS
tedyu : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java

                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>            Assignee: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229970#comment-13229970 ] 

Daniel Gómez Ferro commented on HBASE-5579:
-------------------------------------------

0 wasn't counting before the change. There were 4 versions (0 to 3), the test removed version 1 and assumed "0 doesn't count" so it expected 2 versions.

With this fix, 0 does indeed count and it expects 3 versions correctly.

If we set/check -1 we would have the same problem with version -1, a delete with version > -1 would also mask values inserted at timestamp -1.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230257#comment-13230257 ] 

Lars Hofhansl commented on HBASE-5579:
--------------------------------------

Fair enough. +1 on patch.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230427#comment-13230427 ] 

Zhihong Yu commented on HBASE-5579:
-----------------------------------

Will integrate the patch this evening if there is no objection.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229208#comment-13229208 ] 

Hadoop QA commented on HBASE-5579:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12518314/HBASE-5579.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1185//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1185//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1185//console

This message is automatically generated.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230536#comment-13230536 ] 

Hudson commented on HBASE-5579:
-------------------------------

Integrated in HBase-TRUNK #2683 (See [https://builds.apache.org/job/HBase-TRUNK/2683/])
    HBASE-5579 A Delete Version could mask other values (Daniel Ferro) (Revision 1301173)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java

                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230495#comment-13230495 ] 

Zhihong Yu commented on HBASE-5579:
-----------------------------------

Integrated to TRUNK.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Gómez Ferro updated HBASE-5579:
--------------------------------------

    Status: Patch Available  (was: Open)

The attached patch also fixes TestCompaction.java which was assuming this was the expected behavior.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Gómez Ferro updated HBASE-5579:
--------------------------------------

    Attachment: HBASE-5579.patch
    
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230625#comment-13230625 ] 

Zhihong Yu commented on HBASE-5579:
-----------------------------------

Integrated to 0.94 as well.

Thanks for the patch Daniel.

Thanks for the review, Stack and Lars.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230247#comment-13230247 ] 

Daniel Gómez Ferro commented on HBASE-5579:
-------------------------------------------

Then it could bit someone who inserts values with Long.MIN_VALUE, not something that should happen often but if it happens it is going to be hard to debug.

If you are worried about state variables we could use a Long and reset() it to null, but I think that's not very clean.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Assigned] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu reassigned HBASE-5579:
---------------------------------

    Assignee: Daniel Gómez Ferro
    
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>            Assignee: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5579:
------------------------------

    Fix Version/s: 0.96.0
                   0.94.0
     Hadoop Flags: Reviewed

This should go to 0.94, I assume
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5579:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>            Assignee: Daniel Gómez Ferro
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Gómez Ferro updated HBASE-5579:
--------------------------------------

    Affects Version/s: 0.92.0
    
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229284#comment-13229284 ] 

Zhihong Yu commented on HBASE-5579:
-----------------------------------

{code}
-     * 0 does not count.
{code}
Interesting.

@Nicolas, @Lars:
Please take a look.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230227#comment-13230227 ] 

Lars Hofhansl commented on HBASE-5579:
--------------------------------------

I see. Makes sense.
Maybe use Long.MIN_VALUE?

I'm fine with the patch, just a bit of hesitation, since the more state variables we have the easier it will be in the future to mess this up.

                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

Posted by "Daniel Gómez Ferro (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229232#comment-13229232 ] 

Daniel Gómez Ferro commented on HBASE-5579:
-------------------------------------------

Those tests passed locally.
                
> A Delete Version could mask other values
> ----------------------------------------
>
>                 Key: HBASE-5579
>                 URL: https://issues.apache.org/jira/browse/HBASE-5579
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Daniel Gómez Ferro
>         Attachments: HBASE-5579.patch
>
>
> A Delete Version operation mask values that have version = 0. The problem happens at ScanDeleteTracker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira