You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mnit016 (via GitHub)" <gi...@apache.org> on 2023/08/08 08:36:25 UTC

[GitHub] [pulsar-helm-chart] mnit016 opened a new pull request, #375: Correct Keytool env generation

mnit016 opened a new pull request, #375:
URL: https://github.com/apache/pulsar-helm-chart/pull/375

   Fixes keytool.sh overwriting PULSAR_EXTRA_OPTS & BOOKIE_EXTRA_OPTS 
   
   ### Motivation
   Bookie didn't get configured PULSAR_MEM from chart, because [Keytool.sh Line 100](https://github.com/apache/pulsar-helm-chart/blob/73fe688a439c3ab9b56f2d249f16505292391f4b/charts/pulsar/templates/keytool.yaml#L100) echo a line which overwrite the old env.
   
   ### Modifications
   add a slash in front of $ in order to pass env definition instead of value.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Bookie don't get configured PULSAR_MEM properly from chart [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #375:
URL: https://github.com/apache/pulsar-helm-chart/pull/375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Bookie don't get configured PULSAR_MEM properly from chart [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #375:
URL: https://github.com/apache/pulsar-helm-chart/pull/375#issuecomment-1849636269

   Thanks for the contribution @mnit016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org