You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/12 03:51:07 UTC
[GitHub] [rocketmq] codecov-io commented on issue #1920: [ISSUE #1558]module
`acl` compatible with 1.6
codecov-io commented on issue #1920: [ISSUE #1558]module `acl` compatible with 1.6
URL: https://github.com/apache/rocketmq/pull/1920#issuecomment-612559993
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=h1) Report
> Merging [#1920](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/dc815cc581f9e9dd36efa926fc7087ff1ecbf1a6&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1920 +/- ##
=============================================
- Coverage 45.13% 45.06% -0.08%
+ Complexity 4197 4190 -7
=============================================
Files 544 544
Lines 35727 35733 +6
Branches 4744 4748 +4
=============================================
- Hits 16125 16102 -23
- Misses 17558 17587 +29
Partials 2044 2044
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/rocketmq/acl/common/AclUtils.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0FjbFV0aWxzLmphdmE=) | `83.12% <100.00%> (ø)` | `66.00 <0.00> (ø)` | |
| [...ava/org/apache/rocketmq/acl/common/Permission.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL1Blcm1pc3Npb24uamF2YQ==) | `91.89% <100.00%> (+1.26%)` | `20.00 <0.00> (ø)` | |
| [...apache/rocketmq/acl/plain/PlainAccessResource.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5BY2Nlc3NSZXNvdXJjZS5qYXZh) | `73.33% <100.00%> (ø)` | `28.00 <0.00> (ø)` | |
| [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `70.23% <100.00%> (ø)` | `39.00 <6.00> (ø)` | |
| [...cketmq/acl/plain/RemoteAddressStrategyFactory.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUmVtb3RlQWRkcmVzc1N0cmF0ZWd5RmFjdG9yeS5qYXZh) | `91.20% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `47.52% <0.00%> (-11.89%)` | `12.00% <0.00%> (-3.00%)` | |
| [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
| [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | `16.00% <0.00%> (-2.00%)` | |
| [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `40.00% <0.00%> (-4.45%)` | `7.00% <0.00%> (-1.00%)` | |
| [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.69% <0.00%> (-4.05%)` | `20.00% <0.00%> (-2.00%)` | |
| ... and [8 more](https://codecov.io/gh/apache/rocketmq/pull/1920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=footer). Last update [dc815cc...8633609](https://codecov.io/gh/apache/rocketmq/pull/1920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services