You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/10/21 17:44:00 UTC
[jira] [Commented] (HTTPCLIENT-2123) H2AsyncClientBuilder doesn't
add RequestInterceptorEntry.Postion.LAST with correct method
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218455#comment-17218455 ]
ASF subversion and git services commented on HTTPCLIENT-2123:
-------------------------------------------------------------
Commit 57b972cdee170bbdbfa59539daab79ce690efd28 in httpcomponents-client's branch refs/heads/5.0.x from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=57b972c ]
HTTPCLIENT-2123: H2AsyncClientBuilder incorrectly adds last request interceptors to the head of the interceptor list
> H2AsyncClientBuilder doesn't add RequestInterceptorEntry.Postion.LAST with correct method
> -----------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2123
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2123
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (async)
> Affects Versions: 5.0.3
> Reporter: koji lin
> Priority: Minor
>
> Code at Line 656 adding LAST using addFirst. It should be addLast.
> {code:java}
> if (requestInterceptors != null) {
> for (final RequestInterceptorEntry entry: requestInterceptors) {
> if (entry.postion == RequestInterceptorEntry.Postion.LAST) {
> b.addFirst(entry.interceptor);
> }
> }
> }
> if (responseInterceptors != null) {
> for (final ResponseInterceptorEntry entry: responseInterceptors) {
> if (entry.postion == ResponseInterceptorEntry.Postion.LAST) {
> b.addLast(entry.interceptor);
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org