[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1816: [NETBEANS-3636] Update Spring Framework 4.3.25

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1816: [NETBEANS-3636] Update Spring Framework 4.3.25
URL: https://github.com/apache/netbeans/pull/1816#discussion_r361466734
 
 

 ##########
 File path: java/libs.springframework/external/spring-framework-4.3.25.RELEASE-notice.txt
 ##########
 @@ -0,0 +1,11 @@
+Spring Framework 4.3.25.RELEASE
+Copyright (c) 2002-2019 Pivotal, Inc.
 
 Review comment:
   You can remove everything from this file from line 3 onwards. We are required to carry the _relevant_ information from the NOTICE file of the upstream libraries. In this case lines 4-6 belong into the license file and line 8-11 are two broad to carry anything meaningful.
   
   It would be great if you could update the notice file for 5.X also  (I missed that in that review).
   
   Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists