[GitHub] bbrowning commented on issue #2855: Cache database attachments

[GitBox <gi...@apache.org>]

bbrowning commented on issue #2855: Cache database attachments
URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-380986882
 
 
   I've observed some very poor performance for Java actions and with the help of @rabbah I think I've narrowed it down to the Invokers fetching the Jar attachment on every activation. So, I can confirm both that not caching database attachments is a problem and that this PR is needed.
   
   However, I've as of yet been unable to verify that this PR works as intended. https://gist.github.com/bbrowning/6f18deb9f82282700cd3033deaf127b9#file-gistfile1-txt-L29 is a gist of me invoking an action twice in a row with this PR applied. You'll notice that on the highlighted line, the 2nd invocation still fetches the attachment directly from the database.
   
   There are also a couple of test failures with the PR when applied to the current codebase. Those look to be related to the reduction of Info level logging and some of the log markers the tests are expecting no longer get logged. Here's the failing test output for reference - https://gist.github.com/bbrowning/727158c6c668d9e81d57543fe67f5ff0
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services