You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/11 09:40:02 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2283: sim: Add a config to test libcxx

xiaoxiang781216 opened a new pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283


   ## Summary
   extract from https://github.com/apache/incubator-nuttx/pull/2063, to improve c++ build coverage
   
   ## Impact
   
   ## Testing
   pass the build
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531438399



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       I mean there isn't -Wno-all to restore to the default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#issuecomment-725510941


   @yamt do you know how to fix this warning?
   ```
   In file included from libcxx/src/filesystem/directory_iterator.cpp:19:
   Error: libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
     200 | using TimeSpec = struct ::timespec;
         |                           ^~~~~~~~
   Error: libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
     201 | using StatT = struct ::stat;
         |                        ^~~~
   cc1plus: all warnings being treated as errors
   make[1]: *** [Makefile:87: directory_iterator.o] Error 1
   In file included from libcxx/src/filesystem/operations.cpp:20:
   Error: libcxx/src/filesystem/filesystem_common.h:200:27: error: declaration 'struct timespec' does not declare anything [-Werror]
     200 | using TimeSpec = struct ::timespec;
         |                           ^~~~~~~~
   Error: libcxx/src/filesystem/filesystem_common.h:201:24: error: declaration 'struct stat' does not declare anything [-Werror]
     201 | using StatT = struct ::stat;
         |                        ^~~~
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531428294



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       > Yes, it isn't required for libc++, but I have saw other 3rd party library can't be the warning free with -Wall, and it's hard to disable -Wall by CFLAGS.
   
   how is it hard to disable?
   -Wall is basically a set of -Wxxx. you can disable each of them by -Wno-xxx.
   
   > Do you hit some special issue without -Wall?
   
   no special issue. i just prefer to enable it as it's often useful.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531398437



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       the removal of -Wshadow is explained in the commit message.
   but the removal of -Wall is not. can you explain a bit?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2283: sim: Add a config to test libcxx

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531424483



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       Yes, it isn't required for libc++, but I have saw other 3rd party library can't be the warning free with -Wall, and it's hard to disable -Wall by CFLAGS. Do you hit some special issue without -Wall?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org