You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/02 02:54:28 UTC
[GitHub] [dubbo-go] yaoyinnan opened a new pull request #1429: hession problem at generic invocation filter
yaoyinnan opened a new pull request #1429:
URL: https://github.com/apache/dubbo-go/pull/1429
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
Modify []hessian{} to []string, then go-go generic invocation will cause decode errors.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1429: hession problem at generic invocation filter
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1429:
URL: https://github.com/apache/dubbo-go/pull/1429#discussion_r700741996
##########
File path: filter/generic/service_filter.go
##########
@@ -22,7 +22,7 @@ import (
)
import (
- hessian "github.com/apache/dubbo-go-hessian2"
+ //hessian "github.com/apache/dubbo-go-hessian2"
Review comment:
delete this line directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin edited a comment on pull request #1429: hession problem at generic invocation filter
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin edited a comment on pull request #1429:
URL: https://github.com/apache/dubbo-go/pull/1429#issuecomment-911176637
分支改下，config-enhance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1429: hession problem at generic invocation filter
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1429:
URL: https://github.com/apache/dubbo-go/pull/1429#issuecomment-911176637
分支改下，config-enahnce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yaoyinnan closed pull request #1429: hession problem at generic invocation filter
Posted by GitBox <gi...@apache.org>.
yaoyinnan closed pull request #1429:
URL: https://github.com/apache/dubbo-go/pull/1429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org