You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "MrBlueMoo (via GitHub)" <gi...@apache.org> on 2023/03/27 22:58:23 UTC
[GitHub] [camel] MrBlueMoo opened a new pull request, #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
MrBlueMoo opened a new pull request, #9660:
URL: https://github.com/apache/camel/pull/9660
Duplicate of #9659 for main!
# Description
This functionality allows for delayed delivery options within Apache Pulsar to be used by specifying a time that you want the message to be delivered.
This is simply is a passthrough for setting the deliverAt() on an Apache Pulsar message used used by the producer. The expected value is a Long representing the current timestamp in milliseconds (UTC) which is simply passed across without translation.
The detail of the call used is as follows:
https://pulsar.apache.org/api/client/2.11.x/org/apache/pulsar/client/api/TypedMessageBuilder.html#deliverAt(long)
Uses the CamelPulsarProducerMessageDeliverAt header name for setting.
# Target
- [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue] https://issues.apache.org/jira/browse/CAMEL-19210
# Apache Camel coding standards and style
- [X] I checked that each commit in the pull request has a meaningful subject line and body.
- [X] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9660:
URL: https://github.com/apache/camel/pull/9660#issuecomment-1486234178
Ah you can copy their javadoc as its better
```
Deliver the message only at or after the specified absolute timestamp.
The timestamp is milliseconds and based on UTC (eg: [System.currentTimeMillis()](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/System.html#currentTimeMillis()).
Note: messages are only delivered with delay when a consumer is consuming through a [SubscriptionType.Shared](https://pulsar.apache.org/api/client/2.11.x/org/apache/pulsar/client/api/SubscriptionType.html#Shared) subscription. With other subscription types, the messages will still be delivered immediately.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9660:
URL: https://github.com/apache/camel/pull/9660#issuecomment-1485968110
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] MrBlueMoo commented on pull request #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
Posted by "MrBlueMoo (via GitHub)" <gi...@apache.org>.
MrBlueMoo commented on PR #9660:
URL: https://github.com/apache/camel/pull/9660#issuecomment-1489313202
@davsclaus Thank you, much appreciated, and yes good call on adding additional detail to the description which I see you already actioned (you beat me to it)! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9660:
URL: https://github.com/apache/camel/pull/9660#issuecomment-1486233665
Can the description of the header be a bit more improved. The time is in millis since epoch and I assume its the local time where the client is running. And what happens if the time is in the past? Or if the time is too far in the future (eg +1 year or something) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9660: CAMEL-19210 - Support for delayed delivery pulsar messages using deliverAt (for main)
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9660:
URL: https://github.com/apache/camel/pull/9660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org