You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/06/01 03:00:04 UTC
Re: Review Request 67343: Automatically loaded all the local enabled
cgroups subsystems.
> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/67343/diff/3/?file=2032117#file2032117line108>
> >
> > enabled cgroup subsystems?
I'd like to be consistent with the existing ones, like:
https://github.com/apache/mesos/blob/1.6.0/src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp#L122
I guess we do not need the word `cgroups` here because we are already in the cgroups isolator.
> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 134 (patched)
> > <https://reviews.apache.org/r/67343/diff/3/?file=2032117#file2032117line134>
> >
> > this is not like happen though, but I am thinking if we should return an error and block the agent in this case?
As we discussed, we'd better to error out in this case.
> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 163 (patched)
> > <https://reviews.apache.org/r/67343/diff/3/?file=2032117#file2032117line163>
> >
> > why not const ref?
My bad, thanks for catching this!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204093
-----------------------------------------------------------
On May 30, 2018, 9:05 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 9:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 93197b05eb837d02c6c113264f20a33d6ed92d7f
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 6d663a5770418b7ffe2b3af50b9181ecde183c67
>
>
> Diff: https://reviews.apache.org/r/67343/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>