You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2007/10/05 22:37:50 UTC
[jira] Created: (LUCENE-1021) Unit tests do not fail if a
ConcurrentMergeScheduler thread hits an exception
Unit tests do not fail if a ConcurrentMergeScheduler thread hits an exception
-----------------------------------------------------------------------------
Key: LUCENE-1021
URL: https://issues.apache.org/jira/browse/LUCENE-1021
Project: Lucene - Java
Issue Type: Bug
Components: Index
Affects Versions: 2.3
Reporter: Michael McCandless
Assignee: Michael McCandless
Priority: Minor
Fix For: 2.3
Now that CMS is the default, it's important to fail any unit test that
hits an exception in a CMS thread. But they do not fail now. The
preferred solution (thanks to Erik Hatcher) is to fix all Lucene unit
tests to subclass from a new LuceneTestCase (in o.a.l.util) base that
asserts that there were no such exceptions during the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1021) Unit tests do not fail if a
ConcurrentMergeScheduler thread hits an exception
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1021.
----------------------------------------
Resolution: Fixed
I just committed this.
Please make sure any newly added unit tests for Lucene subclass from LuceneTestCase!
> Unit tests do not fail if a ConcurrentMergeScheduler thread hits an exception
> -----------------------------------------------------------------------------
>
> Key: LUCENE-1021
> URL: https://issues.apache.org/jira/browse/LUCENE-1021
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-1021.patch
>
>
> Now that CMS is the default, it's important to fail any unit test that
> hits an exception in a CMS thread. But they do not fail now. The
> preferred solution (thanks to Erik Hatcher) is to fix all Lucene unit
> tests to subclass from a new LuceneTestCase (in o.a.l.util) base that
> asserts that there were no such exceptions during the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1021) Unit tests do not fail if a
ConcurrentMergeScheduler thread hits an exception
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1021:
---------------------------------------
Attachment: LUCENE-1021.patch
Attached patch.
Note that whenever we add a new Lucene unit test you must subclass
from LuceneTestCase, and take care to call super.setUp() in setUp and
super.tearDown() in tearDown if you override these methods.
> Unit tests do not fail if a ConcurrentMergeScheduler thread hits an exception
> -----------------------------------------------------------------------------
>
> Key: LUCENE-1021
> URL: https://issues.apache.org/jira/browse/LUCENE-1021
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-1021.patch
>
>
> Now that CMS is the default, it's important to fail any unit test that
> hits an exception in a CMS thread. But they do not fail now. The
> preferred solution (thanks to Erik Hatcher) is to fix all Lucene unit
> tests to subclass from a new LuceneTestCase (in o.a.l.util) base that
> asserts that there were no such exceptions during the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org