[GitHub] [incubator-skywalking] BFergerson commented on issue #2342: Force fully qualified endpoint names

[GitBox <gi...@apache.org>]

BFergerson commented on issue #2342: Force fully qualified endpoint names
URL: https://github.com/apache/incubator-skywalking/issues/2342#issuecomment-471366837
 
 
   @wu-sheng, thanks for the quick response. I do just want to tell the difference between the `GET` and `POST`. Having the request method type in the operation name would probably have been sufficient but I'm not sure if that's the only scenario that exists that could create a situation like this. I can implement both if you want but I primarily would like the qualified name as the endpoint. As you say, other services use the qualified name as the endpoint and that's what I've been using for those.
   
   I completely missed the `Config.Plugin` section. That's a better place for this configuration, agreed. I'm thinking the name of `Config.Plugin.SpringMVC.USE_QUALIFIED_NAME_AS_ENDPOINT_NAME`. These are small changes so I'll see what you think about adding the request method in the endpoint name before opening a pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services