You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andrew Wieteska (Jira)" <ji...@apache.org> on 2020/11/26 04:13:00 UTC

[jira] [Commented] (ARROW-8173) [C++] Validate ChunkedArray()'s arguments

    [ https://issues.apache.org/jira/browse/ARROW-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239062#comment-17239062 ] 

Andrew Wieteska commented on ARROW-8173:
----------------------------------------

I *think* these type checks have now been implemented:

https://github.com/apache/arrow/blob/65aa527707d7067bff833bd744ebfd97f1c2c909/cpp/src/arrow/chunked_array.cc#L67-L84

> [C++] Validate ChunkedArray()'s arguments
> -----------------------------------------
>
>                 Key: ARROW-8173
>                 URL: https://issues.apache.org/jira/browse/ARROW-8173
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 0.16.0
>            Reporter: Ben Kietzman
>            Priority: Major
>
> ChunkedArray has constraints on type uniformity of chunks which are currently only expressed in comments. At minimum debug checks should be added to ensure (for example) that an explicit type is shared by all chunks, at best the public constructor should be replaced with {{Result<std::shared_ptr<ChunkedArray>> ChunkedArray::Make(...)}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)