[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #4893: [Metrics][LOG] Add metrics for compaction permits and log for merge rowsets

[GitBox <gi...@apache.org>]

weizuo93 commented on a change in pull request #4893:
URL: https://github.com/apache/incubator-doris/pull/4893#discussion_r528453808



##########
File path: be/src/olap/merger.cpp
##########
@@ -65,6 +65,11 @@ OLAPStatus Merger::merge_rowsets(TabletSharedPtr tablet,
         RETURN_NOT_OK_LOG(dst_rowset_writer->add_row(row_cursor),
                           "failed to write row when merging rowsets of tablet " + tablet->full_name());
         output_rows++;
+        if (config::row_step_for_compaction_merge_log != 0 && output_rows % config::row_step_for_compaction_merge_log == 0) {

Review comment:
       > There is "LOG_EVERY_N" macro for this purpose
   
   OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org