[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #687: HDDS-2184. Rename ozone scmcli to ozone admin

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #687: HDDS-2184. Rename ozone scmcli to ozone admin
URL: https://github.com/apache/hadoop-ozone/pull/687#discussion_r395122832
 
 

 ##########
 File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/SafeModeCommands.java
 ##########
 @@ -46,15 +48,15 @@
       LoggerFactory.getLogger(SafeModeCommands.class);
 
   @ParentCommand
-  private SCMCLI parent;
+  private WithScmClient parent;
 
-  public SCMCLI getParent() {
+  public WithScmClient getParent() {
     return parent;
   }
 
   @Override
   public Void call() throws Exception {
     throw new MissingSubcommandException(
-        this.parent.getCmd().getSubcommands().get("safemode"));
+        new CommandLine(new SafeModeCommands()));
 
 Review comment:
   Previously this printed the full command:
   
   ```
   $ ozone scmcli safemode
   Incomplete command
   Usage: ozone scmcli safemode [-hV] [COMMAND]
   ...
   ```
   
   Now it is only (note the "incomplete" command following `Usage:`):
   
   ```
   $ ozone admin safemode
   Incomplete command
   Usage: safemode [-hV] [COMMAND]
   ...
   ```
   
   I think the first one is more helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org