You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2025/11/22 10:17:11 UTC

[PR] Add svn to GitHub PATH after install [maven-gh-actions-shared]

slawekjaranowski opened a new pull request, #218:
URL: https://github.com/apache/maven-gh-actions-shared/pull/218

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add svn to GitHub PATH after install [maven-gh-actions-shared]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #218:
URL: https://github.com/apache/maven-gh-actions-shared/pull/218#discussion_r2553269026


##########
.github/actions/install-svn/action.yml:
##########
@@ -32,5 +32,12 @@ runs:
 
     - name: Install Subversion on Windows
       if: runner.os == 'Windows'
-      shell: powershell
-      run: choco install --yes svn
+      shell: bash
+      run: |
+        choco install --yes svn
+        echo "C:\Program Files (x86)\Subversion\bin" >> $GITHUB_PATH
+
+    - name: Test Subversion on Windows
+      if: runner.os == 'Windows'

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add svn to GitHub PATH after install [maven-gh-actions-shared]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #218:
URL: https://github.com/apache/maven-gh-actions-shared/pull/218#discussion_r2553267391


##########
.github/actions/install-svn/action.yml:
##########
@@ -32,5 +32,12 @@ runs:
 
     - name: Install Subversion on Windows
       if: runner.os == 'Windows'
-      shell: powershell
-      run: choco install --yes svn
+      shell: bash
+      run: |
+        choco install --yes svn
+        echo "C:\Program Files (x86)\Subversion\bin" >> $GITHUB_PATH
+
+    - name: Test Subversion on Windows
+      if: runner.os == 'Windows'

Review Comment:
   can be on all, on windows I need more test to set path ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add svn to GitHub PATH after install [maven-gh-actions-shared]

Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #218:
URL: https://github.com/apache/maven-gh-actions-shared/pull/218#discussion_r2553253335


##########
.github/actions/install-svn/action.yml:
##########
@@ -32,5 +32,12 @@ runs:
 
     - name: Install Subversion on Windows
       if: runner.os == 'Windows'
-      shell: powershell
-      run: choco install --yes svn
+      shell: bash
+      run: |
+        choco install --yes svn
+        echo "C:\Program Files (x86)\Subversion\bin" >> $GITHUB_PATH
+
+    - name: Test Subversion on Windows
+      if: runner.os == 'Windows'

Review Comment:
   Why test only on Windows?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add svn to GitHub PATH after install [maven-gh-actions-shared]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #218:
URL: https://github.com/apache/maven-gh-actions-shared/pull/218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org