You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/23 14:37:26 UTC
[GitHub] [iceberg] racevedoo opened a new pull request #3798: Core: add test for deadlock in CachingCatalog
racevedoo opened a new pull request #3798:
URL: https://github.com/apache/iceberg/pull/3798
Adds failing test for deadlock described in #3791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] racevedoo closed pull request #3798: Core: add test for deadlock in CachingCatalog
Posted by GitBox <gi...@apache.org>.
racevedoo closed pull request #3798:
URL: https://github.com/apache/iceberg/pull/3798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] racevedoo commented on pull request #3798: Core: add test for deadlock in CachingCatalog
Posted by GitBox <gi...@apache.org>.
racevedoo commented on pull request #3798:
URL: https://github.com/apache/iceberg/pull/3798#issuecomment-1001197451
Superseeded by #3801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] racevedoo commented on a change in pull request #3798: Core: add test for deadlock in CachingCatalog
Posted by GitBox <gi...@apache.org>.
racevedoo commented on a change in pull request #3798:
URL: https://github.com/apache/iceberg/pull/3798#discussion_r774675246
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java
##########
@@ -276,6 +283,44 @@ public void testCacheExpirationIsDisabledByANegativeValue() throws IOException {
catalog.isCacheExpirationEnabled());
}
+ @Test
+ @Ignore("reproduces https://github.com/apache/iceberg/issues/3791")
Review comment:
This test passes with the changes in #3801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3798: Core: add test for deadlock in CachingCatalog
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3798:
URL: https://github.com/apache/iceberg/pull/3798#discussion_r774862595
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java
##########
@@ -276,6 +283,44 @@ public void testCacheExpirationIsDisabledByANegativeValue() throws IOException {
catalog.isCacheExpirationEnabled());
}
+ @Test
+ @Ignore("reproduces https://github.com/apache/iceberg/issues/3791")
Review comment:
Eventually, we might want to put this test into the source (and leave it with the `Ignore`) so it can be reran. At the least lets, reference the other PR here so people will have a higher chance of seeing the link: https://github.com/apache/iceberg/pull/3801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org