[jira] Updated: (DERBY-3050) Convert groupBy.sql tests to JUnit and include them in GroupByTest.java

["Bryan Pendleton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-3050:
-----------------------------------

    Attachment: convertToJUnit.diff
                convertToJUnit.stat

Attached is convertToJUnit.[stat,diff], a patch proposal.

I took groupBy.sql and ran it through the DERBY-2151 converter, and it produced a nearly perfect file. (Wow!) I took the resulting file and merged the code into the existing GroupByTest.java, to make a (much larger) GroupByTest.java which tests GROUP BY processing in JUnit. I also removed the old groupBy.sql and its master files, and removed it from langScripts.

The new GroupByTest runs cleanly as a standalone JUnit test, and my overall runs of derbyall and suites.All were also clean.

Please have a look if you have a chance.

> Convert groupBy.sql tests to JUnit and include them in GroupByTest.java
> -----------------------------------------------------------------------
>
>                 Key: DERBY-3050
>                 URL: https://issues.apache.org/jira/browse/DERBY-3050
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Bryan Pendleton
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: convertToJUnit.diff, convertToJUnit.stat
>
>
> There are currently 3 sets of GROUP BY tests:
>  - GroupByExpressionTest.java
>  - GroupByTest.java
>  - groupBy.sql
> The first two tests are JUnit tests; the groupBy.sql tests are old-style harness tests,
> although they are now run in the JUnit framework using the LangScripts technique.
> This sub-task proposes to convert the groupBy.sql tests to JUnit tests, and to include
> them directly into GroupByTest.java.
> The DERBY-2151 conversion tool can be used to assist in the conversion process.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.