[echarts-examples] branch dev updated: fix build example gl

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/echarts-examples.git


The following commit(s) were added to refs/heads/dev by this push:
     new ce296d0  fix build example gl
ce296d0 is described below

commit ce296d05b1aeeb827b95c85599c386b34cdbe47b
Author: pissang <bm...@gmail.com>
AuthorDate: Thu Sep 16 14:53:45 2021 +0800

    fix build example gl
---
 tool/build-example.js   | 7 ++++---
 tool/compile-example.js | 6 +++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/tool/build-example.js b/tool/build-example.js
index 32a26cc..eec520a 100644
--- a/tool/build-example.js
+++ b/tool/build-example.js
@@ -37,7 +37,8 @@ const parser = new argparse.ArgumentParser({
   addHelp: true
 });
 parser.addArgument(['--gl'], {
-  help: 'If generating gl'
+  help: 'If generating gl',
+  action: 'storeTrue'
 });
 parser.addArgument(['-t', '--theme'], {
   help: 'Theme list, default to be all'
@@ -69,7 +70,7 @@ const DEFAULT_PAGE_RATIO = 0.75;
 const OUTPUT_IMAGE_WIDTH = 600;
 const OUTPUT_IMAGE_HEIGHT = OUTPUT_IMAGE_WIDTH * DEFAULT_PAGE_RATIO;
 
-const PORT = 3323;
+const PORT = 3324;
 const BASE_URL = `http://localhost:${PORT}`;
 const SCREENSHOT_PAGE_URL = `${BASE_URL}/tool/screenshot.html`;
 
@@ -285,7 +286,7 @@ async function takeScreenshot(
         // TODO Examples that can't work temporary.
         basename === 'bar3d-music-visualization'
       ) {
-        return;
+        continue;
       }
 
       const tsFile = `${examplesRoot}/ts/${isGL ? 'gl/' : ''}${basename}.ts`;
diff --git a/tool/compile-example.js b/tool/compile-example.js
index 321bf4c..7840baa 100644
--- a/tool/compile-example.js
+++ b/tool/compile-example.js
@@ -27,9 +27,9 @@ async function run() {
     fs.writeFileSync(file, content, 'utf-8');
   }
 
-  if (hasError) {
-    shell.exit(1);
-  }
+  // if (hasError) {
+  //   shell.exit(1);
+  // }
 }
 
 run();

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org