You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org> on 2005/12/11 22:45:08 UTC

[jira] Created: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
-----------------------------------------------------------------------------------------------------------------------

         Key: GERONIMO-1336
         URL: http://issues.apache.org/jira/browse/GERONIMO-1336
     Project: Geronimo
        Type: Bug
  Components: console  
    Versions: 1.0-M5    
    Reporter: Matt Hogstrom
 Assigned to: Joe Bohn 
     Fix For: 1.0


When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.

13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
java.lang.IllegalArgumentException: Max size must be positive, not -1
        at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
        at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
        at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
        at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
        at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
        at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
        at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
        at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
        at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
        at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
        at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
        at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
        at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
        at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
        at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Matt Hogstrom updated GERONIMO-1336:
------------------------------------

    Fix Version: 1.1
                     (was: 1.0)

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Joe Bohn
>      Fix For: 1.1

>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Joe Bohn updated GERONIMO-1336:
-------------------------------

    Attachment: DBPoolValidate2.patch

Aaron, I've updated the patch to ensure that min < max.  The patch already prevented submit for the deploy and plan but not for test, so I have added that as well.  I also realized that there is a different jsp involved in the creation vs. the edit so I've made the same updates to the create wizard jsp.
Note:  This patch was created from geronimo root in trunk on winXP.

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch, DBPoolValidate2.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Donald Woods updated GERONIMO-1336:
-----------------------------------

    Fix Version: 1.0.1
                     (was: 1.1)

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>      Fix For: 1.0.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Matt Hogstrom reassigned GERONIMO-1336:
---------------------------------------

    Assign To: Matt Hogstrom  (was: Joe Bohn)

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>      Fix For: 1.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Donald Woods updated GERONIMO-1336:
-----------------------------------

    Fix Version: 1.1
       Priority: Minor  (was: Major)

Validated patch against latest 1.0 branch.

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Joe Bohn updated GERONIMO-1336:
-------------------------------

    Geronimo Info: [Patch Available]

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Joe Bohn
>      Fix For: 1.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Matt Hogstrom reassigned GERONIMO-1336:
---------------------------------------

    Assign To: Matt Hogstrom  (was: Aaron Mulder)

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch, DBPoolValidate2.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Joe Bohn updated GERONIMO-1336:
-------------------------------

    Attachment: DBPoolValidate.patch

Updated the JSP to validate that the min pool is >= 0 and the max pool is > 0 prior to submit. 
This patch was created from the root Geronimo directory.

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Joe Bohn
>      Fix For: 1.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]
     
Matt Hogstrom closed GERONIMO-1336:
-----------------------------------

    Resolution: Fixed

branches/1.0

svn commit -m "Geronimo-1336 Corrected issue when specifying database pool sizes"   
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/confirmURL.jsp
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/edit.jsp
Transmitting file data ..
Committed revision 374252.


trunk

svn commit -m "Geronimo-1336 Corrected issue when specifying database pool sizes"
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/confirmURL.jsp
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/edit.jsp
Transmitting file data ..
Committed revision 374253.


> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch, DBPoolValidate2.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Joe Bohn (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Joe Bohn reassigned GERONIMO-1336:
----------------------------------

    Assign To: Aaron Mulder  (was: Matt Hogstrom)

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Aaron Mulder
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch, DBPoolValidate2.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=comments#action_12364032 ] 

Aaron Mulder commented on GERONIMO-1336:
----------------------------------------

Joe, could you adjust the patch to not submit the form if there's an error (so the user can review the stuff) and also to validate that the max size is greater than the min size if both values are present?  Thanks.

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.1, 1.0.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira