You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by li...@apache.org on 2024/04/24 01:24:51 UTC

(superset) branch move-actual-comparison-range created (now a4418061fa)

This is an automated email from the ASF dual-hosted git repository.

lilykuang pushed a change to branch move-actual-comparison-range
in repository https://gitbox.apache.org/repos/asf/superset.git


      at a4418061fa chore(time-comparison-table): move actual comparison range in control panel

This branch includes the following new commits:

     new a4418061fa chore(time-comparison-table): move actual comparison range in control panel

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: chore(time-comparison-table): move actual comparison range in control panel

Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lilykuang pushed a commit to branch move-actual-comparison-range
in repository https://gitbox.apache.org/repos/asf/superset.git

commit a4418061fa826159423792db78c94bfda7c8e1ae
Author: lilykuang <ji...@gmail.com>
AuthorDate: Tue Apr 23 10:42:44 2024 -0700

    chore(time-comparison-table): move actual comparison range in control panel
---
 .../plugin-chart-table/src/controlPanel.tsx        | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index 802dddb1b4..b6ac2785c5 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -338,6 +338,17 @@ const config: ControlPanelConfig = {
             },
           },
         ],
+        [
+          {
+            name: 'comparison_range_label',
+            config: {
+              type: 'ComparisonRangeLabel',
+              visibility: ({ controls }) =>
+                Boolean(controls?.enable_time_comparison?.value) &&
+                isAggMode({ controls }),
+            },
+          },
+        ],
         [
           {
             name: `adhoc_custom`,
@@ -406,17 +417,6 @@ const config: ControlPanelConfig = {
             },
           },
         ],
-        [
-          {
-            name: 'comparison_range_label',
-            config: {
-              type: 'ComparisonRangeLabel',
-              visibility: ({ controls }) =>
-                Boolean(controls?.enable_time_comparison?.value) &&
-                isAggMode({ controls }),
-            },
-          },
-        ],
         [
           {
             name: 'row_limit',