You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/10/25 06:58:20 UTC

[GitHub] [kylin] hit-lacus commented on pull request #2001: KYLIN-5279 Default null collation for Kylin5.0 sqls should be null-last for ASC order and null-first for DESC order.

hit-lacus commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290073592

   Here is my suggestion.You don't need add a new config entry like: `kylin.query.asc-order-null-first-enable`. 
   
   Looks like you can reuse existent config entry in `KylinConfigBase#getCalciteExtrasProperties` and remove the overwrite method `defaultNullCollation` of KECalciteConfig.  After that, you 
   just need set "kylin.query.calcite.extras-props.defaultNullCollation=low/high/first/last" in kylin.properties .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org