[GitHub] [incubator-mxnet] yugoren commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl

[GitBox <gi...@apache.org>]

yugoren commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-509333261
 
 
   Thanks for the explanation @TaoLv. Here are some questions inlined.
   
   > @nuslq, this is as expected. libmkldnn.so and libmklml_intel.so will be dynamically linked even USE_STATIC_MKL is true. Actually, they are not the `MKL` in `USE_STATIC_MKL`. Please refer to the logic here: https://github.com/dmlc/mshadow/blob/master/make/mshadow.mk#L87
   
   As far as we can trace, the only instance where the `MKL` usage flag, `MSHADOW_USE_MKL` is set in CMake files but not in Makefile. Could you confirm that? 
   
   >  * `USE_BLAS=mkl` and `USE_STATIC_MKL` are for how to link MKL BLAS. They can be used even `USE_MKLDNN=0` (in this case, you will not see the mkldnn.so and mklml_intel.so in ldd).
   > 
   >  * mklml_intel.so is introduced along with `USE_MKLDNN=1` to improve the performance of mkldnn.so. mklml_intel cannot be statically linked as no `.a` file is provided.
   > 
   > 
   > Hope this explanation can address your questions. So the fix for lower case `use_blas` looks good. But the change and description for `USE_STATIC_MKL` does not make sense to me.
   
   I feel like there is more to understand which flags (as compiler and linker flags) are absolutely necessary for MxNet to compile with MKL BLAS support, using `make` or `cmake`. Moreover, I cannot find any place in `mshadow` code the compiler definition  `MSHADOW_USE_MKL`, but only in `MxNet` operators, which is never set with Makefile (as far as I can trace). This was one of the reasons we wanted to remark on `USE_STATIC_MKL` since we couldn't find the aforementioned compiler definition set.
   
   Could you or @larroy clarify what we're missing here?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services