You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/25 18:51:45 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10404: KAFKA-12557: Fix hanging KafkaAdminClientTest

ijuma commented on a change in pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#discussion_r601759185



##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java
##########
@@ -113,6 +114,9 @@ public MockClient kafkaClient() {
 
     @Override
     public void close() {
+        // tell the admin client to close now
+        this.adminClient.close(Duration.ZERO);
+        // block until it is really closed
         this.adminClient.close();

Review comment:
       Seems like we should do a single `close` with some timeout. cc @cmccabe 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org