[GitHub] [airflow] bbovenzi commented on a change in pull request #17477: Open relative extra links in place

[GitBox <gi...@apache.org>]

bbovenzi commented on a change in pull request #17477:
URL: https://github.com/apache/airflow/pull/17477#discussion_r685094417



##########
File path: airflow/www/static/js/dag.js
##########
@@ -190,6 +190,8 @@ export function callModal(t, d, extraLinks, tryNumbers, sd) {
           cache: false,
           success(data) {
             externalLink.attr('href', data.url);
+            if(/^(?:[a-z]+:)?\/\//.test(data.url))

Review comment:
       Let's put a comment above this line to explain that the regex detects local vs external routes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org