You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/01 12:27:35 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5948: libc/lib_localtime:fix deadcode

pkarashchenko commented on a change in pull request #5948:
URL: https://github.com/apache/incubator-nuttx/pull/5948#discussion_r840536668



##########
File path: libs/libc/time/lib_localtime.c
##########
@@ -1585,14 +1583,7 @@ static int tzparse(FAR const char *name, FAR struct state_s *sp,
                    * offset.
                    */
 
-                  if (isdst && !sp->ttis[j].tt_ttisstd)

Review comment:
       I agree that code seems to be dead, but let's try to spend some time and analyze if `isdst` update is missing somewhere or maybe the condition is wrong




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org