[GitHub] [apisix] membphis commented on a diff in pull request #8157: feat: renew route lrucache when the routes change

[GitBox <gi...@apache.org>]

membphis commented on code in PR #8157:
URL: https://github.com/apache/apisix/pull/8157#discussion_r1002968432


##########
apisix/plugins/ai.lua:
##########
@@ -280,7 +281,8 @@ end
 
 
 function _M.init_worker()
-    orig_router_match = router.router_http.match
+    orig_router_match = base_router.match_uri

Review Comment:
   we need a better name for `orig_router_match`



##########
apisix/plugins/ai.lua:
##########
@@ -70,21 +67,20 @@ local orig_http_balancer_phase = apisix.http_balancer_phase
 
 local default_keepalive_pool = {}
 
-local function match_route(ctx)
-    orig_router_match(ctx)
-    return ctx.matched_route or false
+local function match_route(uri_router, match_opts, api_ctx)

Review Comment:
   we need a better name: `match_route `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org